Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1502)

Unified Diff: chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc

Issue 10700007: Page actions behave as disableable browser actions when script badges are enabled. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc
diff --git a/chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc b/chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc
index 826c117e7013d5a6ee7cff693c9fc4f6792fda49..e26037be9efe992e56c133b6dfd9e6155411b75d 100644
--- a/chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc
+++ b/chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc
@@ -87,6 +87,11 @@ void BrowserActionOverflowMenuController::CancelMenu() {
menu_->Cancel();
}
+bool BrowserActionOverflowMenuController::IsCommandEnabled(int id) const {
+ BrowserActionView* view = (*views_)[start_index_ + id - 1];
+ return view->button()->IsEnabled(owner_->GetCurrentTabId());
not at google - send to devlin 2012/07/12 01:07:29 Same comment here and in the GTK code: ExtensionT
Yoyo Zhou 2012/07/12 01:33:27 I seem to recall this changes the appearance of me
+}
+
void BrowserActionOverflowMenuController::ExecuteCommand(int id) {
BrowserActionView* view = (*views_)[start_index_ + id - 1];
owner_->OnBrowserActionExecuted(view->button());

Powered by Google App Engine
This is Rietveld 408576698