chrome/common/extensions/extension.cc - Issue 10700007: Page actions behave as disableable browser actions when script badges are enabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/extension.cc

Issue 10700007: Page actions behave as disableable browser actions when script badges are enabled. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc ('K') | « chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/extension.cc

diff --git a/chrome/common/extensions/extension.cc b/chrome/common/extensions/extension.cc

index 9671778df129e6bb40a9bf18a6e79a7c705db052..59d97ef6d0a6aca86aa83b93ec83d14fe0ea6aa9 100644

--- a/chrome/common/extensions/extension.cc

+++ b/chrome/common/extensions/extension.cc

@@ -805,9 +805,10 @@ scoped_ptr<ExtensionAction> Extension::LoadExtensionActionHelper(

string16* error) {

scoped_ptr<ExtensionAction> result(new ExtensionAction(id(), action_type));

- // Page actions are hidden by default, and browser actions ignore

- // visibility.

- result->SetIsVisible(ExtensionAction::kDefaultTabId, false);

+ // Page actions are hidden/disabled by default, and browser actions are

+ // visible/enabled by default.

+ result->SetIsVisible(ExtensionAction::kDefaultTabId,

+ action_type != ExtensionAction::TYPE_PAGE);

if (manifest_version_ == 1) {

ListValue* icons = NULL;