Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10698163: Make miscellaneous_bindings.js not depend on onLoad(). (Closed)

Created:
8 years, 5 months ago by koz (OOO until 15th September)
Modified:
8 years, 4 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, benwells
Visibility:
Public.

Description

Make miscellaneous_bindings.js not depend on onLoad(). BUG=136469 TBR=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149145

Patch Set 1 #

Total comments: 4

Patch Set 2 : respond to comments #

Patch Set 3 : add missing line #

Patch Set 4 : rebase #

Patch Set 5 : fix 'compile' error #

Patch Set 6 : fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -38 lines) Patch
M chrome/renderer/extensions/chrome_v8_context.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/renderer/extensions/chrome_v8_context.cc View 1 2 3 4 chunks +14 lines, -14 lines 0 comments Download
M chrome/renderer/extensions/extension_dispatcher.cc View 1 2 3 4 5 3 chunks +60 lines, -3 lines 0 comments Download
M chrome/renderer/resources/extensions/extension_custom_bindings.js View 1 2 3 4 5 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/renderer/resources/extensions/miscellaneous_bindings.js View 1 2 chunks +4 lines, -21 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
koz (OOO until 15th September)
Just some cleanup, moving slowly towards testability / simplicity.
8 years, 5 months ago (2012-07-12 03:42:16 UTC) #1
not at google - send to devlin
lgtm http://codereview.chromium.org/10698163/diff/1/chrome/renderer/extensions/chrome_v8_context.cc File chrome/renderer/extensions/chrome_v8_context.cc (right): http://codereview.chromium.org/10698163/diff/1/chrome/renderer/extensions/chrome_v8_context.cc#newcode46 chrome/renderer/extensions/chrome_v8_context.cc:46: << GetContextTypeDescription(); Doesn't fit on 1 line? http://codereview.chromium.org/10698163/diff/1/chrome/renderer/resources/extensions/miscellaneous_bindings.js ...
8 years, 5 months ago (2012-07-12 05:47:41 UTC) #2
koz (OOO until 15th September)
http://codereview.chromium.org/10698163/diff/1/chrome/renderer/extensions/chrome_v8_context.cc File chrome/renderer/extensions/chrome_v8_context.cc (right): http://codereview.chromium.org/10698163/diff/1/chrome/renderer/extensions/chrome_v8_context.cc#newcode46 chrome/renderer/extensions/chrome_v8_context.cc:46: << GetContextTypeDescription(); On 2012/07/12 05:47:41, kalman wrote: > Doesn't ...
8 years, 5 months ago (2012-07-12 06:06:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/koz@chromium.org/10698163/8001
8 years, 5 months ago (2012-07-12 06:10:48 UTC) #4
commit-bot: I haz the power
Failed to apply patch for chrome/renderer/extensions/extension_dispatcher.cc: While running patch -p1 --forward --force; patching file chrome/renderer/extensions/extension_dispatcher.cc ...
8 years, 5 months ago (2012-07-12 06:10:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/koz@chromium.org/10698163/10001
8 years, 5 months ago (2012-07-16 04:07:49 UTC) #6
commit-bot: I haz the power
Try job failure for 10698163-10001 (retry) on linux_rel for step "browser_tests". It's a second try, ...
8 years, 5 months ago (2012-07-16 07:00:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/koz@chromium.org/10698163/19001
8 years, 5 months ago (2012-07-18 06:31:22 UTC) #8
commit-bot: I haz the power
Try job failure for 10698163-19001 (retry) on mac_rel for step "browser_tests". It's a second try, ...
8 years, 5 months ago (2012-07-18 07:37:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/koz@chromium.org/10698163/27001
8 years, 4 months ago (2012-07-31 05:57:44 UTC) #10
commit-bot: I haz the power
Presubmit check for 10698163-27001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-07-31 05:57:48 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/koz@chromium.org/10698163/27001
8 years, 4 months ago (2012-07-31 06:07:05 UTC) #12
commit-bot: I haz the power
8 years, 4 months ago (2012-07-31 07:21:16 UTC) #13 
Change committed as 149145

Powered by Google App Engine
This is Rietveld 408576698