Make miscellaneous_bindings.js not depend on onLoad().

chrome/renderer/extensions/chrome_v8_context.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/extensions/chrome_v8_context.h"
 
 #include "base/debug/trace_event.h"
 #include "base/logging.h"
 #include "base/string_split.h"
 #include "base/values.h"
@@ skipping 11 matching lines @@
 
 namespace {
 
 const char kChromeHidden[] = "chromeHidden";
 
 #ifndef NDEBUG
 const char kValidateCallbacks[] = "validateCallbacks";
 const char kValidateAPI[] = "validateAPI";
 #endif
 
-std::string GetContextTypeDescription(Feature::Context context_type) {
-  switch (context_type) {
-    case Feature::UNSPECIFIED_CONTEXT:         return "UNSPECIFIED";
-    case Feature::BLESSED_EXTENSION_CONTEXT:   return "BLESSED_EXTENSION";
-    case Feature::UNBLESSED_EXTENSION_CONTEXT: return "UNBLESSED_EXTENSION";
-    case Feature::CONTENT_SCRIPT_CONTEXT:      return "CONTENT_SCRIPT";
-    case Feature::WEB_PAGE_CONTEXT:            return "WEB_PAGE";
-  }
-  NOTREACHED();
-  return "";
-}
-
 }  // namespace
 
 ChromeV8Context::ChromeV8Context(v8::Handle<v8::Context> v8_context,
                                  WebKit::WebFrame* web_frame,
                                  const extensions::Extension* extension,
                                  Feature::Context context_type)
     : v8_context_(v8::Persistent<v8::Context>::New(v8_context)),
       web_frame_(web_frame),
       extension_(extension),
       context_type_(context_type) {
   VLOG(1) << "Created context:\n"
           << "  extension id: " << GetExtensionID() << "\n"
           << "  frame:        " << web_frame_ << "\n"
-          << "  context type: " << GetContextTypeDescription(context_type);
+          << "  context type: "
+          << GetContextTypeDescription();

[not at google - send to devlin, 2012/07/12 05:47:41]

Doesn't fit on 1 line?

[koz (OOO until 15th September), 2012/07/12 06:06:12]

Done.

 }
 
 ChromeV8Context::~ChromeV8Context() {
   VLOG(1) << "Destroyed context for extension\n"
           << "  extension id: " << GetExtensionID();
   v8_context_.Dispose();
 }
 
 std::string ChromeV8Context::GetExtensionID() {
   return extension_ ? extension_->id() : "";
@@ skipping 94 matching lines @@
             UserScriptSlave::GetDataSourceURLForFrame(web_frame_)).Pass();
   }
   return *(available_extension_apis_.get());
 }
 
 void ChromeV8Context::DispatchOnLoadEvent(bool is_incognito_process,
                                           int manifest_version) {
   v8::HandleScope handle_scope;
   v8::Handle<v8::Value> argv[] = {
     v8::String::New(GetExtensionID().c_str()),
-    v8::String::New(GetContextTypeDescription(context_type_).c_str()),
+    v8::String::New(GetContextTypeDescription().c_str()),
     v8::Boolean::New(is_incognito_process),
     v8::Integer::New(manifest_version),
   };
   CallChromeHiddenMethod("dispatchOnLoad", arraysize(argv), argv, NULL);
 }
 
 void ChromeV8Context::DispatchOnUnloadEvent() {
   v8::HandleScope handle_scope;
   CallChromeHiddenMethod("dispatchOnUnload", 0, NULL, NULL);
 }
+
+std::string ChromeV8Context::GetContextTypeDescription() {
+  switch (context_type_) {
+    case Feature::UNSPECIFIED_CONTEXT:         return "UNSPECIFIED";
+    case Feature::BLESSED_EXTENSION_CONTEXT:   return "BLESSED_EXTENSION";
+    case Feature::UNBLESSED_EXTENSION_CONTEXT: return "UNBLESSED_EXTENSION";
+    case Feature::CONTENT_SCRIPT_CONTEXT:      return "CONTENT_SCRIPT";
+    case Feature::WEB_PAGE_CONTEXT:            return "WEB_PAGE";
+  }
+  NOTREACHED();
+  return "";
+}