Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 10698123: Fix Debug::Break crash. (Closed)

Created:
8 years, 5 months ago by Yang
Modified:
8 years, 5 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Fix Debug::Break crash. BUG=131642 TEST=test-debug/Regress131642 Committed: https://code.google.com/p/v8/source/detail?r=12019

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -75 lines) Patch
M src/debug.h View 1 chunk +0 lines, -8 lines 0 comments Download
M src/debug.cc View 2 chunks +8 lines, -66 lines 0 comments Download
M src/execution.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/runtime.cc View 1 chunk +3 lines, -1 line 0 comments Download
M test/cctest/test-debug.cc View 1 chunk +43 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Yang
Please take a look. The test case explains the bug.
8 years, 5 months ago (2012-07-09 14:26:51 UTC) #1
Michael Starzinger
8 years, 5 months ago (2012-07-09 15:14:51 UTC) #2
LGTM. Nice catch!

Powered by Google App Engine
This is Rietveld 408576698