Support for lists in debugger wire protocol

tools/ddbg.dart

Index: tools/ddbg.dart
===================================================================
--- tools/ddbg.dart	(revision 9233)
+++ tools/ddbg.dart	(working copy)
@@ -36,9 +36,10 @@
   sbp [<file>] <line> Set breakpoint
   rbp <id> Remove breakpoint with given id
   po <id> Print object info for given id
+  pl <id> <idx> [<len>] Print list element/slice
   pc <id> Print class info for given id
   ll  List loaded libraries
-  pl <id> Print library info for given library id
+  plib <id> Print library info for given library id
   pg <id> Print all global variables visible within given library id
   ls <libname> List loaded scripts in library
   gs <lib_id> <script_url> Get source text of script in library
@@ -113,11 +114,24 @@
     var cmd = { "id": seqNum, "command": "getObjectProperties",
                 "params": {"objectId": Math.parseInt(args[1]) }};
     sendCmd(cmd).then((result) => handleGetObjPropsResponse(result));
+  } else if (command == "pl" && args.length >= 3) {
+     var cmd;
+     if (args.length == 3) {
+       cmd = { "id": seqNum, "command": "getListElements",
+                "params": {"objectId": Math.parseInt(args[1]),
+                            "index": Math.parseInt(args[2]) }};
+    } else {
+       cmd = { "id": seqNum, "command": "getListElements",
+                "params": {"objectId": Math.parseInt(args[1]),
+                            "index": Math.parseInt(args[2]),
+                            "length": Math.parseInt(args[3]) }};
+    }
+    sendCmd(cmd).then((result) => handleGetListResponse(result));
   } else if (command == "pc" && args.length == 2) {
     var cmd = { "id": seqNum, "command": "getClassProperties",
                 "params": {"classId": Math.parseInt(args[1]) }};
     sendCmd(cmd).then((result) => handleGetClassPropsResponse(result));
-  } else if (command == "pl" && args.length == 2) {
+  } else if (command == "plib" && args.length == 2) {
     var cmd = { "id": seqNum, "command": "getLibraryProperties",
                 "params": {"libraryId": Math.parseInt(args[1]) }};
     sendCmd(cmd).then((result) => handleGetLibraryPropsResponse(result));
@@ -144,14 +158,17 @@
 }
 
 
-String remoteValue(value) {
+String remoteObject(value) {
   var kind = value["kind"];
   var text = value["text"];
   var id = value["objectId"];
   if (kind == "string") {
-    return "'$text'";
+    return "(string, id $id) '$text'";
+  } else if (kind == "list") {
+    var len = value["length"];
+    return "(list, id $id, len $len) $text";
   } else if (kind == "object") {
-    return "(obj id: $id) = $text";
+    return "(obj, id $id) $text";
   } else {
     return "$text";
   }
@@ -161,7 +178,7 @@
 printNamedObject(obj) {
   var name = obj["name"];
   var value = obj["value"];
-  print("  $name = ${remoteValue(value)}");
+  print("  $name = ${remoteObject(value)}");
 }
 
 
@@ -179,7 +196,27 @@
   }
 }
 
+handleGetListResponse(response) {
+  Map result = response["result"];
+  if (result["elements"] != null) {
+    // List slice.
+    var index = result["index"];
+    var length = result["length"];
+    List elements = result["elements"];
+    assert(length == elements.length);
+    for (int i = 0; i < length; i++) {
+      String kind = elements[i]["kind"];
+      String text = elements[i]["text"];

[siva, 2012/06/29 00:16:22]

maybe:

var kind = ...;
var text = ...;

[hausner, 2012/06/29 00:52:11]

Ok. I use types at a few places to make sure the data structure is what I expect
it to be. But it's not necessary here.

On 2012/06/29 00:16:22, asiva wrote:

+      print("  ${index + i}: ($kind) $text");
+    }
+  } else {
+    // One element, a remote object.
+    print(result);
+    print("  ${remoteObject(result)}");
+  }
+}
 
+
 handleGetClassPropsResponse(response) {
   Map props = response["result"];
   assert(props["name"] != null);
@@ -311,7 +348,7 @@
     assert(reason == "exception");
     var excObj = msg["params"]["exception"];
     print("VM paused on exception");
-    print(remoteValue(excObj));
+    print(remoteObject(excObj));
   }
   print("Stack trace:");
   printStackTrace(stackTrace);