Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 10698039: Support for lists in debugger wire protocol (Closed)

Created:
8 years, 5 months ago by hausner
Modified:
8 years, 5 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, devoncarew
Visibility:
Public.

Description

Support for lists in debugger wire protocol Committed: https://code.google.com/p/dart/source/detail?r=9235

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -33 lines) Patch
M runtime/bin/dbg_connection.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/dbg_connection.cc View 13 chunks +141 lines, -26 lines 0 comments Download
M tools/ddbg.dart View 1 6 chunks +44 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
hausner
8 years, 5 months ago (2012-06-28 23:40:42 UTC) #1
siva
lgtm http://codereview.chromium.org/10698039/diff/1/tools/ddbg.dart File tools/ddbg.dart (right): http://codereview.chromium.org/10698039/diff/1/tools/ddbg.dart#newcode209 tools/ddbg.dart:209: String text = elements[i]["text"]; maybe: var kind = ...
8 years, 5 months ago (2012-06-29 00:16:22 UTC) #2
hausner
8 years, 5 months ago (2012-06-29 00:52:11 UTC) #3
Thank you Siva.

http://codereview.chromium.org/10698039/diff/1/tools/ddbg.dart
File tools/ddbg.dart (right):

http://codereview.chromium.org/10698039/diff/1/tools/ddbg.dart#newcode209
tools/ddbg.dart:209: String text = elements[i]["text"];
Ok. I use types at a few places to make sure the data structure is what I expect
it to be. But it's not necessary here.

On 2012/06/29 00:16:22, asiva wrote:
> maybe:
> 
> var kind = ...;
> var text = ...;

Powered by Google App Engine
This is Rietveld 408576698