Register JNI for content_unittests.

Register JNI for content_unittests.

Also split the content_jni_registrar into app,browser and common.

BUG=125059
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=144951

[Yaron, 2012-06-29 02:49:22]

lgtm but I'd prefer you get jam's approval

http://codereview.chromium.org/10697030/diff/1/content/content_browser.gypi
File content/content_browser.gypi (right):

http://codereview.chromium.org/10697030/diff/1/content/content_browser.gypi#n...
content/content_browser.gypi:189:
'browser/android/content_browser_jni_registrar.cc',
Nit: sort order

[jam, 2012-06-29 15:57:04]

lgtm, but I'd get rid of the "Content" in the class names and "content" in
filenames since it seems redundant. I think you're probably modelling it after
ContentBrowserClient etc. I regret putting Content in their name since they're
already in the content namespace, but I was modelling it after the WebKit api
which had WebKit::WebKitClient. in this case, you're not calling them from
embedders since they're internal to content, so def no need for the extra
content

[nilesh, 2012-06-29 17:25:32]

On 2012/06/29 15:57:04, John Abd-El-Malek wrote:
> lgtm, but I'd get rid of the "Content" in the class names and "content" in
> filenames since it seems redundant. I think you're probably modelling it after
> ContentBrowserClient etc. I regret putting Content in their name since they're
> already in the content namespace, but I was modelling it after the WebKit api
> which had WebKit::WebKitClient. in this case, you're not calling them from
> embedders since they're internal to content, so def no need for the extra
> content

Removed content from filenames and methods. Thanks for the review.

[commit-bot: I haz the power, 2012-06-29 17:25:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/10697030/6002

[commit-bot: I haz the power, 2012-06-29 17:25:54]

Failed to apply patch for content/browser/android/browser_jni_registrar.cc:
While running patch -p1 --forward --force;
patching file content/browser/android/browser_jni_registrar.cc
Hunk #2 FAILED at 14.
1 out of 2 hunks FAILED -- saving rejects to file
content/browser/android/browser_jni_registrar.cc.rej

[commit-bot: I haz the power, 2012-06-29 17:40:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/10697030/7003

[nilesh, 2012-06-29 18:04:52]

http://codereview.chromium.org/10697030/diff/1/content/content_browser.gypi
File content/content_browser.gypi (right):

http://codereview.chromium.org/10697030/diff/1/content/content_browser.gypi#n...
content/content_browser.gypi:189:
'browser/android/content_browser_jni_registrar.cc',
On 2012/06/29 02:49:22, Yaron wrote:
> Nit: sort order

Done.

[commit-bot: I haz the power, 2012-06-29 19:11:02]

Change committed as 144951