Moving record API to api/record/ .

Moving record API to api/record/ .


BUG=101244
TEST=N/A, only moving code, no change in functionality


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146079

[vabr (Chromium), 2012-07-10 11:27:26]

Hi Aaron, could you please review this?

Cc-ing clintstaley@, who appears to have touched this code recently, and I don't
want to break whatever work is going on there.

Cheers,

Vaclav

[clintstaley_gmail.com, 2012-07-10 16:20:38]

lgtm -- no work here should be adversely affected.

Clint

On 7/10/2012 4:27 AM, vabr@chromium.org wrote:
> Reviewers: Aaron Boodman,
>
> Message:
> Hi Aaron, could you please review this?
>
> Cc-ing clintstaley@, who appears to have touched this code recently, 
> and I don't
> want to break whatever work is going on there.
>
> Cheers,
>
> Vaclav
>
> Description:
> Moving record API to api/record/ .
>
>
> BUG=101244
> TEST=N/A, only moving code, no change in functionality
>
>
> Please review this at https://chromiumcodereview.appspot.com/10696144/
>
> SVN Base: http://git.chromium.org/chromium/src.git@master
>
> Affected files:
>   A + chrome/browser/extensions/api/record/record_api.h
>   A + chrome/browser/extensions/api/record/record_api.cc
>   A + chrome/browser/extensions/api/record/record_api_test.cc
>   M chrome/browser/extensions/extension_function_registry.cc
>   D chrome/browser/extensions/extension_record_api.h
>   D chrome/browser/extensions/extension_record_api.cc
>   D chrome/browser/extensions/extension_record_api_test.cc
>   M chrome/chrome_browser_extensions.gypi
>   M chrome/chrome_tests.gypi
>
>
>

[Aaron Boodman, 2012-07-10 21:53:55]

lgtm

http://codereview.chromium.org/10696144/diff/1/chrome/browser/extensions/exte...
File chrome/browser/extensions/extension_function_registry.cc (right):

http://codereview.chromium.org/10696144/diff/1/chrome/browser/extensions/exte...
chrome/browser/extensions/extension_function_registry.cc:245:
RegisterFunction<extensions::CaptureURLsFunction>();
Why move?

[vabr (Chromium), 2012-07-11 06:24:54]

Thanks, Clinton and Aaron.

I am putting this into CQ since you both agreed, but I still answered Aaron's
comment, and will watch if Aaron wants to change something about that piece of
code.

Cheers,

Vaclav

http://codereview.chromium.org/10696144/diff/1/chrome/browser/extensions/exte...
File chrome/browser/extensions/extension_function_registry.cc (right):

http://codereview.chromium.org/10696144/diff/1/chrome/browser/extensions/exte...
chrome/browser/extensions/extension_function_registry.cc:245:
RegisterFunction<extensions::CaptureURLsFunction>();
On 2012/07/10 21:53:55, Aaron Boodman wrote:
> Why move?

Do you mean -- why move the RegisterFunction clauses, or why move into
extensions namespace?
If the first then note that I did not move them, only deleted duplicates.

[commit-bot: I haz the power, 2012-07-11 06:25:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vabr@chromium.org/10696144/1

[commit-bot: I haz the power, 2012-07-11 07:36:46]

Change committed as 146079