[Android] Upstream all the IPC communications/handlings for stream texture

[Android] Upstream all the IPC communications/handlings for stream texture

We have already upstreamed the StreamTextureListener and StreamTextureBridge class at the browser side.
Also the renderer side StreamTexureFactory has been upstreamed for media player.
This change upstreams all the missing IPCs/handlers between these classes.

BUG=
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146508

[jam, 2012-07-12 20:22:24]

I'm not that familiar with the gpu side, so I defer to gpu owners.

adding apatrick/kbr since they're owners in both content/common/gpu and
content/renderer/gpu. only need one to review of course

http://codereview.chromium.org/10695181/diff/1/content/common/gpu/gpu_channel.h
File content/common/gpu/gpu_channel.h (right):

http://codereview.chromium.org/10695181/diff/1/content/common/gpu/gpu_channel...
content/common/gpu/gpu_channel.h:147: // Register the StreamTexutreProxy class
with the gpu process so that all
nit: spelling

http://codereview.chromium.org/10695181/diff/1/content/renderer/render_view_i...
File content/renderer/render_view_impl.cc (right):

http://codereview.chromium.org/10695181/diff/1/content/renderer/render_view_i...
content/renderer/render_view_impl.cc:2345: NULL, NULL, routing_id_));
nit: can fit on one line

[qinmin, 2012-07-12 20:53:30]

http://codereview.chromium.org/10695181/diff/1/content/common/gpu/gpu_channel.h
File content/common/gpu/gpu_channel.h (right):

http://codereview.chromium.org/10695181/diff/1/content/common/gpu/gpu_channel...
content/common/gpu/gpu_channel.h:147: // Register the StreamTexutreProxy class
with the gpu process so that all
On 2012/07/12 20:22:24, John Abd-El-Malek wrote:
> nit: spelling

Done.

http://codereview.chromium.org/10695181/diff/1/content/renderer/render_view_i...
File content/renderer/render_view_impl.cc (right):

http://codereview.chromium.org/10695181/diff/1/content/renderer/render_view_i...
content/renderer/render_view_impl.cc:2345: NULL, NULL, routing_id_));
On 2012/07/12 20:22:24, John Abd-El-Malek wrote:
> nit: can fit on one line

Done.

[apatrick_chromium, 2012-07-12 23:51:30]

Just nits. I spoke to Daniel and we plan to more deeply unify it with the rest
of the texture sharing mechanisms but this is fine for now. LGTM.

http://codereview.chromium.org/10695181/diff/1/content/common/gpu/gpu_messages.h
File content/common/gpu/gpu_messages.h (right):

http://codereview.chromium.org/10695181/diff/1/content/common/gpu/gpu_message...
content/common/gpu/gpu_messages.h:29: #include "ui/gfx/rect.h"
I don't think you used gfx::Rect.

http://codereview.chromium.org/10695181/diff/1/content/common/gpu/stream_text...
File content/common/gpu/stream_texture_manager_android.h (right):

http://codereview.chromium.org/10695181/diff/1/content/common/gpu/stream_text...
content/common/gpu/stream_texture_manager_android.h:74: { matrix_callback_ =
callback; }
nit: google style

http://codereview.chromium.org/10695181/diff/1/content/renderer/gpu/stream_te...
File content/renderer/gpu/stream_texture_host_android.cc (right):

http://codereview.chromium.org/10695181/diff/1/content/renderer/gpu/stream_te...
content/renderer/gpu/stream_texture_host_android.cc:58: if (channel_.get())
braces for multiline if body.

http://codereview.chromium.org/10695181/diff/1/content/renderer/gpu/stream_te...
File content/renderer/gpu/stream_texture_host_android.h (right):

http://codereview.chromium.org/10695181/diff/1/content/renderer/gpu/stream_te...
content/renderer/gpu/stream_texture_host_android.h:27:
StreamTextureHost(GpuChannelHost* channel);
explicit

http://codereview.chromium.org/10695181/diff/1/content/renderer/media/stream_...
File content/renderer/media/stream_texture_factory_impl_android.cc (right):

http://codereview.chromium.org/10695181/diff/1/content/renderer/media/stream_...
content/renderer/media/stream_texture_factory_impl_android.cc:30:
StreamTextureProxyImpl(content::StreamTextureHost* host);
explicit

http://codereview.chromium.org/10695181/diff/1/content/renderer/media/stream_...
content/renderer/media/stream_texture_factory_impl_android.cc:31: virtual
~StreamTextureProxyImpl() OVERRIDE;
this isn't an override.

http://codereview.chromium.org/10695181/diff/5001/content/common/gpu/gpu_mess...
File content/common/gpu/gpu_messages.h (right):

http://codereview.chromium.org/10695181/diff/5001/content/common/gpu/gpu_mess...
content/common/gpu/gpu_messages.h:29: #include "ui/gfx/rect.h"
I don't think you used Rect.

http://codereview.chromium.org/10695181/diff/5001/content/common/gpu/stream_t...
File content/common/gpu/stream_texture_manager_android.h (right):

http://codereview.chromium.org/10695181/diff/5001/content/common/gpu/stream_t...
content/common/gpu/stream_texture_manager_android.h:7: #pragma once
pragma once is not allowed anymore.

http://codereview.chromium.org/10695181/diff/5001/content/common/gpu/stream_t...
content/common/gpu/stream_texture_manager_android.h:36: uint32 client_id)
OVERRIDE;
indentation is out

http://codereview.chromium.org/10695181/diff/5001/content/renderer/gpu/stream...
File content/renderer/gpu/stream_texture_host_android.cc (right):

http://codereview.chromium.org/10695181/diff/5001/content/renderer/gpu/stream...
content/renderer/gpu/stream_texture_host_android.cc:58: if (channel_.get())
nit: multiline if body should have braces.

http://codereview.chromium.org/10695181/diff/5001/content/renderer/media/stre...
File content/renderer/media/stream_texture_factory_impl_android.cc (right):

http://codereview.chromium.org/10695181/diff/5001/content/renderer/media/stre...
content/renderer/media/stream_texture_factory_impl_android.cc:31: virtual
~StreamTextureProxyImpl() OVERRIDE;
not an override.

http://codereview.chromium.org/10695181/diff/5001/content/renderer/media/stre...
content/renderer/media/stream_texture_factory_impl_android.cc:66: if
(loop_.get())
multiline if body should have braces.

http://codereview.chromium.org/10695181/diff/5001/content/renderer/media/stre...
File content/renderer/media/stream_texture_factory_impl_android.h (right):

http://codereview.chromium.org/10695181/diff/5001/content/renderer/media/stre...
content/renderer/media/stream_texture_factory_impl_android.h:28: virtual
~StreamTextureFactoryImpl() OVERRIDE;
This isn't an override.

[jam, 2012-07-12 23:57:21]

lgtm

http://codereview.chromium.org/10695181/diff/5001/content/renderer/gpu/stream...
File content/renderer/gpu/stream_texture_host_android.cc (right):

http://codereview.chromium.org/10695181/diff/5001/content/renderer/gpu/stream...
content/renderer/gpu/stream_texture_host_android.cc:56:
content::SurfaceTexturePeer::SurfaceTextureTarget type,
nit: no need for "content::"

http://codereview.chromium.org/10695181/diff/5001/content/renderer/media/stre...
File content/renderer/media/stream_texture_factory_impl_android.cc (right):

http://codereview.chromium.org/10695181/diff/5001/content/renderer/media/stre...
content/renderer/media/stream_texture_factory_impl_android.cc:121: stream_id,
content::SurfaceTexturePeer::SET_VIDEO_SURFACE_TEXTURE,
ditto

[qinmin, 2012-07-13 00:41:33]

http://codereview.chromium.org/10695181/diff/1/content/common/gpu/gpu_messages.h
File content/common/gpu/gpu_messages.h (right):

http://codereview.chromium.org/10695181/diff/1/content/common/gpu/gpu_message...
content/common/gpu/gpu_messages.h:29: #include "ui/gfx/rect.h"
removed.

On 2012/07/12 23:51:30, apatrick_chromium wrote:
> I don't think you used gfx::Rect.

http://codereview.chromium.org/10695181/diff/1/content/common/gpu/stream_text...
File content/common/gpu/stream_texture_manager_android.h (right):

http://codereview.chromium.org/10695181/diff/1/content/common/gpu/stream_text...
content/common/gpu/stream_texture_manager_android.h:74: { matrix_callback_ =
callback; }
On 2012/07/12 23:51:31, apatrick_chromium wrote:
> nit: google style

Done.

http://codereview.chromium.org/10695181/diff/1/content/renderer/gpu/stream_te...
File content/renderer/gpu/stream_texture_host_android.cc (right):

http://codereview.chromium.org/10695181/diff/1/content/renderer/gpu/stream_te...
content/renderer/gpu/stream_texture_host_android.cc:58: if (channel_.get())
On 2012/07/12 23:51:31, apatrick_chromium wrote:
> braces for multiline if body.

Done.

http://codereview.chromium.org/10695181/diff/1/content/renderer/gpu/stream_te...
File content/renderer/gpu/stream_texture_host_android.h (right):

http://codereview.chromium.org/10695181/diff/1/content/renderer/gpu/stream_te...
content/renderer/gpu/stream_texture_host_android.h:27:
StreamTextureHost(GpuChannelHost* channel);
On 2012/07/12 23:51:31, apatrick_chromium wrote:
> explicit

Done.

http://codereview.chromium.org/10695181/diff/1/content/renderer/media/stream_...
File content/renderer/media/stream_texture_factory_impl_android.cc (right):

http://codereview.chromium.org/10695181/diff/1/content/renderer/media/stream_...
content/renderer/media/stream_texture_factory_impl_android.cc:30:
StreamTextureProxyImpl(content::StreamTextureHost* host);
On 2012/07/12 23:51:31, apatrick_chromium wrote:
> explicit

Done.

http://codereview.chromium.org/10695181/diff/1/content/renderer/media/stream_...
content/renderer/media/stream_texture_factory_impl_android.cc:31: virtual
~StreamTextureProxyImpl() OVERRIDE;
On 2012/07/12 23:51:31, apatrick_chromium wrote:
> this isn't an override.

Done.

http://codereview.chromium.org/10695181/diff/5001/content/common/gpu/gpu_mess...
File content/common/gpu/gpu_messages.h (right):

http://codereview.chromium.org/10695181/diff/5001/content/common/gpu/gpu_mess...
content/common/gpu/gpu_messages.h:29: #include "ui/gfx/rect.h"
removed
On 2012/07/12 23:51:31, apatrick_chromium wrote:
> I don't think you used Rect.

http://codereview.chromium.org/10695181/diff/5001/content/common/gpu/stream_t...
File content/common/gpu/stream_texture_manager_android.h (right):

http://codereview.chromium.org/10695181/diff/5001/content/common/gpu/stream_t...
content/common/gpu/stream_texture_manager_android.h:7: #pragma once
On 2012/07/12 23:51:31, apatrick_chromium wrote:
> pragma once is not allowed anymore.

Done.

http://codereview.chromium.org/10695181/diff/5001/content/common/gpu/stream_t...
content/common/gpu/stream_texture_manager_android.h:36: uint32 client_id)
OVERRIDE;
On 2012/07/12 23:51:31, apatrick_chromium wrote:
> indentation is out

Done.

http://codereview.chromium.org/10695181/diff/5001/content/renderer/gpu/stream...
File content/renderer/gpu/stream_texture_host_android.cc (right):

http://codereview.chromium.org/10695181/diff/5001/content/renderer/gpu/stream...
content/renderer/gpu/stream_texture_host_android.cc:56:
content::SurfaceTexturePeer::SurfaceTextureTarget type,
On 2012/07/12 23:57:21, John Abd-El-Malek wrote:
> nit: no need for "content::"

Done.

http://codereview.chromium.org/10695181/diff/5001/content/renderer/gpu/stream...
content/renderer/gpu/stream_texture_host_android.cc:58: if (channel_.get())
On 2012/07/12 23:51:31, apatrick_chromium wrote:
> nit: multiline if body should have braces.

Done.

http://codereview.chromium.org/10695181/diff/5001/content/renderer/media/stre...
File content/renderer/media/stream_texture_factory_impl_android.cc (right):

http://codereview.chromium.org/10695181/diff/5001/content/renderer/media/stre...
content/renderer/media/stream_texture_factory_impl_android.cc:31: virtual
~StreamTextureProxyImpl() OVERRIDE;
On 2012/07/12 23:51:31, apatrick_chromium wrote:
> not an override.

Done.

http://codereview.chromium.org/10695181/diff/5001/content/renderer/media/stre...
content/renderer/media/stream_texture_factory_impl_android.cc:66: if
(loop_.get())
On 2012/07/12 23:51:31, apatrick_chromium wrote:
> multiline if body should have braces.

Done.

http://codereview.chromium.org/10695181/diff/5001/content/renderer/media/stre...
content/renderer/media/stream_texture_factory_impl_android.cc:121: stream_id,
content::SurfaceTexturePeer::SET_VIDEO_SURFACE_TEXTURE,
On 2012/07/12 23:57:21, John Abd-El-Malek wrote:
> ditto

Done.

http://codereview.chromium.org/10695181/diff/5001/content/renderer/media/stre...
File content/renderer/media/stream_texture_factory_impl_android.h (right):

http://codereview.chromium.org/10695181/diff/5001/content/renderer/media/stre...
content/renderer/media/stream_texture_factory_impl_android.h:28: virtual
~StreamTextureFactoryImpl() OVERRIDE;
On 2012/07/12 23:51:31, apatrick_chromium wrote:
> This isn't an override.

Done.

[commit-bot: I haz the power, 2012-07-13 00:42:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/qinmin@chromium.org/10695181/14001

[commit-bot: I haz the power, 2012-07-13 00:42:07]

Presubmit check for 10695181-14001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit ERRORS **
Do not use #pragma once in header files.
See http://www.chromium.org/developers/coding-style#TOC-File-headers
  content/renderer/gpu/stream_texture_host_android.h

Presubmit checks took 1.0s to calculate.

[commit-bot: I haz the power, 2012-07-13 00:45:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/qinmin@chromium.org/10695181/13002

[commit-bot: I haz the power, 2012-07-13 02:17:24]

Change committed as 146508