Issue 10695101: Remove code that forces text directionality.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10695101: Remove code that forces text directionality. (Closed)

Created:
8 years, 5 months ago by msw

Modified:
8 years, 4 months ago

Reviewers:
xji

CC:
chromium-reviews, tfarina, James Su

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Patch Set 2 : Remove directionality forcing and modes; may be incorrect... #

Total comments: 1

Patch Set 3 : Sync and merge. #

Patch Set 4 : Sync and merge. #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -213 lines)			Patch
M	ui/gfx/canvas.h	View	1 2 3	1 chunk	+1 line, -15 lines	0 comments	Download
M	ui/gfx/canvas_skia.cc	View	1 2 3	4 chunks	+9 lines, -44 lines	0 comments	Download
M	ui/views/controls/label.h	View	1 2 3	3 chunks	+3 lines, -38 lines	0 comments	Download
M	ui/views/controls/label.cc	View	1	4 chunks	+12 lines, -27 lines	0 comments	Download
M	ui/views/controls/label_unittest.cc	View	1	15 chunks	+18 lines, -80 lines	0 comments	Download
M	ui/views/controls/message_box_view.cc	View	1 2 3	1 chunk	+5 lines, -9 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

xji

http://codereview.chromium.org/10695101/diff/2001/ui/views/controls/label.cc File ui/views/controls/label.cc (right): http://codereview.chromium.org/10695101/diff/2001/ui/views/controls/label.cc#newcode123 ui/views/controls/label.cc:123: } so the alignment is also based on text ...

8 years, 5 months ago (2012-07-10 19:59:57 UTC) #1

msw

8 years, 4 months ago (2012-07-28 01:21:46 UTC) #2

I'm abandoning this CL, in favor of another (and followups):
http://codereview.chromium.org/10807082/
Thanks for the feedback!