HiDPI chromium logo for NTP, about:version, about:neterror

HiDPI chromium logo for NTP, about:version, about:neterror

BUG=134372, 135179
TEST=look at logo

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=145466

[Nico, 2012-06-30 05:27:35]

Since the NTP is so visible, it might be worth landing this until grit does the
img rewriting automatically. If you agree, I'll clean replace the XXX comments
with links to the auto-rewrite bug.

[flackr, 2012-06-30 12:05:46]

Sounds like a good idea to me.

http://codereview.chromium.org/10695052/diff/1/chrome/browser/resources/about...
File chrome/browser/resources/about_version.html (right):

http://codereview.chromium.org/10695052/diff/1/chrome/browser/resources/about...
chrome/browser/resources/about_version.html:44: content: -webkit-image-set(
Why not use here?
content: url('chrome://theme/IDR_PRODUCT_LOGO');

http://codereview.chromium.org/10695052/diff/1/chrome/browser/resources/about...
chrome/browser/resources/about_version.html:75: <img id="logo-img">
We should probably use div tags since we're styling the content in CSS even
though it does require specifying display as well.

http://codereview.chromium.org/10695052/diff/1/chrome/browser/resources/ntp4/...
File chrome/browser/resources/ntp4/new_tab.html (right):

http://codereview.chromium.org/10695052/diff/1/chrome/browser/resources/ntp4/...
chrome/browser/resources/ntp4/new_tab.html:106: <img id="logo-img"
style="content:-webkit-image-set(url('chrome://theme/IDR_PRODUCT_LOGO') 1x,
url('chrome://theme/IDR_PRODUCT_LOGO@2x') 2x);">
Could we move this to new_tab.css so you don't have to do the full image-set
specification here?

http://codereview.chromium.org/10695052/diff/1/chrome/renderer/resources/nete...
File chrome/renderer/resources/neterror.html (right):

http://codereview.chromium.org/10695052/diff/1/chrome/renderer/resources/nete...
chrome/renderer/resources/neterror.html:155: <!-- Revert once XXX is done -->
If we're not allowed to load chrome://theme/ resources here fixing grit to do
automatic conversion won't help.

[Nico, 2012-06-30 16:55:25]

http://codereview.chromium.org/10695052/diff/1/chrome/renderer/resources/nete...
File chrome/renderer/resources/neterror.html (right):

http://codereview.chromium.org/10695052/diff/1/chrome/renderer/resources/nete...
chrome/renderer/resources/neterror.html:155: <!-- Revert once XXX is done -->
On 2012/06/30 12:05:46, flackr wrote:
> If we're not allowed to load chrome://theme/ resources here fixing grit to do
> automatic conversion won't help.

I thought img src="relative path" would be made to work too?

[flackr, 2012-06-30 17:02:46]

http://codereview.chromium.org/10695052/diff/1/chrome/renderer/resources/nete...
File chrome/renderer/resources/neterror.html (right):

http://codereview.chromium.org/10695052/diff/1/chrome/renderer/resources/nete...
chrome/renderer/resources/neterror.html:155: <!-- Revert once XXX is done -->
Not outside of chrome/browser/resources, otherwise yes.

On 2012/06/30 16:55:25, Nico wrote:
> On 2012/06/30 12:05:46, flackr wrote:
> > If we're not allowed to load chrome://theme/ resources here fixing grit to
do
> > automatic conversion won't help.
> 
> I thought img src="relative path" would be made to work too?

[Nico, 2012-06-30 18:15:23]

http://codereview.chromium.org/10695052/diff/1/chrome/renderer/resources/nete...
File chrome/renderer/resources/neterror.html (right):

http://codereview.chromium.org/10695052/diff/1/chrome/renderer/resources/nete...
chrome/renderer/resources/neterror.html:155: <!-- Revert once XXX is done -->
On 2012/06/30 17:02:46, flackr wrote:
> Not outside of chrome/browser/resources, otherwise yes.
> 
> On 2012/06/30 16:55:25, Nico wrote:
> > On 2012/06/30 12:05:46, flackr wrote:
> > > If we're not allowed to load chrome://theme/ resources here fixing grit to
> do
> > > automatic conversion won't help.
> > 
> > I thought img src="relative path" would be made to work too?
> 

Ah, right. Will change.

[Nico, 2012-07-04 11:26:56]

I prefer using an img element for the images instead of a div though, so I kept
that part. Addressed the rest.

[flackr, 2012-07-04 12:33:01]

On 2012/07/04 11:26:56, Nico wrote:
> I prefer using an img element for the images instead of a div though, so I
kept
> that part. Addressed the rest.

Reason I suggested changing it to a div is since src is normally a required
attribute of an img, but then so is alt. Anyways, LGTM.