chrome/browser/speech/speech_input_extension_manager.h - Issue 10694085: Refactor extension event distribution to use Values instead of JSON strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/speech/speech_input_extension_manager.h

Issue 10694085: Refactor extension event distribution to use Values instead of JSON strings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixing memory leak in a test. Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/speech/extension_api/tts_extension_api_controller.cc ('k') | chrome/browser/speech/speech_input_extension_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/speech/speech_input_extension_manager.h

diff --git a/chrome/browser/speech/speech_input_extension_manager.h b/chrome/browser/speech/speech_input_extension_manager.h

index 4ef3bce0ab7fc7ec9438c2362f9b8dd8e1de1a81..8f12a68f8070a9ca5b63ba9017d73f93d091a7b0 100644

--- a/chrome/browser/speech/speech_input_extension_manager.h

+++ b/chrome/browser/speech/speech_input_extension_manager.h

@@ -16,6 +16,10 @@

class Profile;

+namespace base {

+class ListValue;

namespace content {

class NotificationRegistrar;

struct SpeechRecognitionError;

@@ -172,7 +176,7 @@ class SpeechInputExtensionManager

void DispatchError(const std::string& error, bool dispatch_event);

void DispatchEventToExtension(const std::string& extension_id,

const std::string& event,

- const std::string& json_args);

+ scoped_ptr<base::ListValue> event_args);

void ExtensionUnloaded(const std::string& extension_id);

void ResetToIdleState();