chrome/browser/speech/extension_api/tts_extension_api_controller.cc - Issue 10694085: Refactor extension event distribution to use Values instead of JSON strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/speech/extension_api/tts_extension_api_controller.cc

Issue 10694085: Refactor extension event distribution to use Values instead of JSON strings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixing memory leak in a test. Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/speech/extension_api/tts_engine_extension_api.cc ('k') | chrome/browser/speech/speech_input_extension_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/speech/extension_api/tts_extension_api_controller.cc

diff --git a/chrome/browser/speech/extension_api/tts_extension_api_controller.cc b/chrome/browser/speech/extension_api/tts_extension_api_controller.cc

index b8df2f8b335e50918618152761acda6ae6bc1047..b54318cf5983cbe985e8f4d09ad9c2d1b3cdbeb7 100644

--- a/chrome/browser/speech/extension_api/tts_extension_api_controller.cc

+++ b/chrome/browser/speech/extension_api/tts_extension_api_controller.cc

@@ -108,7 +108,6 @@ void Utterance::OnTtsEvent(TtsEventType event_type,

if (src_id_ < 0)

return;

- ListValue args;

DictionaryValue* event = new DictionaryValue();

if (char_index != kInvalidCharIndex)

event->SetInteger(constants::kCharIndexKey, char_index);

@@ -118,14 +117,14 @@ void Utterance::OnTtsEvent(TtsEventType event_type,

}

event->SetInteger(constants::kSrcIdKey, src_id_);

event->SetBoolean(constants::kIsFinalEventKey, finished_);

- args.Set(0, event);

- std::string json_args;

- base::JSONWriter::Write(&args, &json_args);

+ scoped_ptr<ListValue> arguments(new ListValue());

+ arguments->Set(0, event);

profile_->GetExtensionEventRouter()->DispatchEventToExtension(

src_extension_id_,

events::kOnEvent,

- json_args,

+ arguments.Pass(),

profile_,

src_url_);

}