Add read-only access to POST data for webRequest's onBeforeRequest

chrome/browser/extensions/api/web_request/web_request_api.h

Index: chrome/browser/extensions/api/web_request/web_request_api.h
diff --git a/chrome/browser/extensions/api/web_request/web_request_api.h b/chrome/browser/extensions/api/web_request/web_request_api.h
index e3925990d8111869dfea31e94d194b92551c07a0..e44487fdf2fcd121ebc1f212775a57693087b4b1 100644
--- a/chrome/browser/extensions/api/web_request/web_request_api.h
+++ b/chrome/browser/extensions/api/web_request/web_request_api.h
@@ -99,6 +99,7 @@ class ExtensionWebRequestEventRouter
       RESPONSE_HEADERS = 1<<1,
       BLOCKING = 1<<2,
       ASYNC_BLOCKING = 1<<3,
+      POST_DATA = 1<<4,
     };
 
     static bool InitFromValue(const base::ListValue& value,
@@ -443,4 +444,10 @@ class WebRequestHandlerBehaviorChanged : public SyncIOThreadExtensionFunction {
 // TODO(mpcomplete): remove. http://crbug.com/100411
 void SendExtensionWebRequestStatusToHost(content::RenderProcessHost* host);
 

[wtc, 2012/08/01 17:24:41]

The URL "crbug.com/10694055" is wrong.  10694055 is a code
review, not a bug report.

[vabr (Chromium), 2012/08/02 09:15:15]

Changed the number to the bug number. Thanks!

+// PostData feature (crbug.com/10694055/) is currently only available in dev
+// and canary channels. This function caches the channel info from

[wtc, 2012/08/01 17:24:41]

Nit: channel => release channel

Should we document that this function returns true for the
Canary and Dev channels only?  (I don't know what
CHANNEL_UNKNOWN means.)

[vabr (Chromium), 2012/08/02 09:15:15]

Added "release".

As for documenting that it returns true for dev/canary, I changed "available" to
"enabled" in the comment, so that it agrees with the name of the function. Is it
now clearer?

+// chrome::VersionInfo. It is used both in WebRequest implementation and in
+// tests, so it needs to be in this header.
+bool IsPostDataEnabled();

[Matt Perry, 2012/08/01 09:46:31]

Use a more descriptive name for a global function like this. (As in, put
WebRequest somewhere in there, to avoid name collisions).

[vabr (Chromium), 2012/08/01 18:03:22]

Done.

+
 #endif  // CHROME_BROWSER_EXTENSIONS_API_WEB_REQUEST_WEB_REQUEST_API_H_