Add read-only access to POST data for webRequest's onBeforeRequest

chrome/browser/extensions/api/web_request/web_request_api.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_API_WEB_REQUEST_WEB_REQUEST_API_H_
 #define CHROME_BROWSER_EXTENSIONS_API_WEB_REQUEST_WEB_REQUEST_API_H_
 
 #include <list>
 #include <map>
 #include <set>
@@ skipping 81 matching lines @@
 
   // Internal representation of the extraInfoSpec parameter on webRequest
   // events, used to specify extra information to be included with network
   // events.
   struct ExtraInfoSpec {
     enum Flags {
       REQUEST_HEADERS = 1<<0,
       RESPONSE_HEADERS = 1<<1,
       BLOCKING = 1<<2,
       ASYNC_BLOCKING = 1<<3,
+      POST_DATA = 1<<4,
     };
 
     static bool InitFromValue(const base::ListValue& value,
                               int* extra_info_spec);
   };
 
   // Contains an extension's response to a blocking event.
   struct EventResponse {
     EventResponse(const std::string& extension_id,
                   const base::Time& extension_install_time);
@@ skipping 323 matching lines @@
   // Handle quota exceeded gracefully: Only warn the user but still execute the
   // function.
   virtual void OnQuotaExceeded() OVERRIDE;
   virtual bool RunImpl() OVERRIDE;
 };
 
 // Send updates to |host| with information about what webRequest-related
 // extensions are installed.
 // TODO(mpcomplete): remove. http://crbug.com/100411
 void SendExtensionWebRequestStatusToHost(content::RenderProcessHost* host);
 

[wtc, 2012/08/01 17:24:41]

The URL "crbug.com/10694055" is wrong.  10694055 is a code
review, not a bug report.

[vabr (Chromium), 2012/08/02 09:15:15]

Changed the number to the bug number. Thanks!

+// PostData feature (crbug.com/10694055/) is currently only available in dev
+// and canary channels. This function caches the channel info from

[wtc, 2012/08/01 17:24:41]

Nit: channel => release channel

Should we document that this function returns true for the
Canary and Dev channels only?  (I don't know what
CHANNEL_UNKNOWN means.)

[vabr (Chromium), 2012/08/02 09:15:15]

Added "release".

As for documenting that it returns true for dev/canary, I changed "available" to
"enabled" in the comment, so that it agrees with the name of the function. Is it
now clearer?

+// chrome::VersionInfo. It is used both in WebRequest implementation and in
+// tests, so it needs to be in this header.
+bool IsPostDataEnabled();

[Matt Perry, 2012/08/01 09:46:31]

Use a more descriptive name for a global function like this. (As in, put
WebRequest somewhere in there, to avoid name collisions).

[vabr (Chromium), 2012/08/01 18:03:22]

Done.

+
 #endif  // CHROME_BROWSER_EXTENSIONS_API_WEB_REQUEST_WEB_REQUEST_API_H_