chrome/browser/resources/safe_browsing_malware_block.html - Issue 10694037: Add a policy to disable proceeding through the Safe Browsing interstitials.

Unified Diff: chrome/browser/resources/safe_browsing_malware_block.html

Issue 10694037: Add a policy to disable proceeding through the Safe Browsing interstitials. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Fixed <button>/jstemplate Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/profiles/profile.cc ('k') | chrome/browser/resources/safe_browsing_multiple_threat_block.html » ('j') | chrome/browser/resources/safe_browsing_multiple_threat_block.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/safe_browsing_malware_block.html

diff --git a/chrome/browser/resources/safe_browsing_malware_block.html b/chrome/browser/resources/safe_browsing_malware_block.html

index 56f4eca0574b12c0617c3c79406c20a49e58f10d..1404cfb0794e2e25f87919e26f30eda74b254f02 100644

--- a/chrome/browser/resources/safe_browsing_malware_block.html

+++ b/chrome/browser/resources/safe_browsing_malware_block.html

@@ -143,24 +143,29 @@ label.checkbox > span {

</head>

-<div class="background"><img src="ssl_roadblock_background.png" width="100%" height="100%" alt="background" onmousedown="return false;"/></div>

+<div class="background"><img src="ssl_roadblock_background.png" width="100%"

James Hawkins 2012/07/02 15:56:06 <img> needs to be on a new line.

Joao da Silva 2012/07/03 13:39:52 Done.

+ height="100%" alt="background" onmousedown="return false;"/></div>

James Hawkins 2012/07/02 15:56:06 nit: </div> must be on a new line since the <div>

James Hawkins 2012/07/02 15:56:06 Why do you need to specify the onmousedown here?

Joao da Silva 2012/07/03 13:39:52 Done.

Joao da Silva 2012/07/03 13:39:52 I honestly don't know why this is here. Please not

- <div class="icon"><img src="shared/images/phishing_icon.png" alt="Malware Icon" onmousedown="return false;"/></div>

+ <div class="icon"><img src="shared/images/phishing_icon.png"

+ alt="Malware Icon" onmousedown="return false;"/></div>

- <div class="main" i18n-values=".innerHTML:description5" id="detailinfo" style="display:block"></div>

+ <div class="main" i18n-values=".innerHTML:description5" id="detailinfo"

James Hawkins 2012/07/02 15:56:06 nit: ID must be the first attribute specified.

Joao da Silva 2012/07/03 13:39:52 Done.

+ style="display:block"></div>

James Hawkins 2012/07/02 15:56:06 <div> is already display: block.

Joao da Silva 2012/07/03 13:39:52 Done.

- <input type="button" class="green" id="back" i18n-values="value:back_button" onclick="sendCommand('takeMeBack')">

+ <button class="green" id="back" i18n-content="back_button"

+ onclick="sendCommand('takeMeBack')"></button>

<br>

</form>

</div>

- <div class="main" i18n-values=".innerHTML:description3"></div>

+ <div class="main" i18n-values=".innerHTML:description3"

+ jsdisplay="!proceedDisabled"></div>