chrome/browser/resources/safe_browsing_malware_block.html - Issue 10694037: Add a policy to disable proceeding through the Safe Browsing interstitials.

Side by Side Diff: chrome/browser/resources/safe_browsing_malware_block.html

Issue 10694037: Add a policy to disable proceeding through the Safe Browsing interstitials. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Fixed <button>/jstemplate Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/profiles/profile.cc ('k') | chrome/browser/resources/safe_browsing_multiple_threat_block.html » ('j') | chrome/browser/resources/safe_browsing_multiple_threat_block.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html id="template_root" i18n-values="dir:textdirection">	2 <html id="template_root" i18n-values="dir:textdirection">

3 <head>	3 <head>

4 <title i18n-content="title"></title>	4 <title i18n-content="title"></title>

5 <style>	5 <style>

6 body {	6 body {

7 background-color:#500;	7 background-color:#500;

8 font-family:Helvetica,Arial,sans-serif;	8 font-family:Helvetica,Arial,sans-serif;

9 margin:0px;	9 margin:0px;

10 }	10 }

(...skipping 125 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
136 if (checkBox.checked) {	136 if (checkBox.checked) {

137 sendCommand('doReport');	137 sendCommand('doReport');

138 } else {	138 } else {

139 sendCommand('dontReport');	139 sendCommand('dontReport');

140 }	140 }

141 }	141 }

142 </script>	142 </script>

143	143

144 </head>	144 </head>

145 <body oncontextmenu="return false;">	145 <body oncontextmenu="return false;">

146 <div class="background"><img src="ssl_roadblock_background.png" width="100%" hei ght="100%" alt="background" onmousedown="return false;"/></div>	146 <div class="background"><img src="ssl_roadblock_background.png" width="100%"
	James Hawkins 2012/07/02 15:56:06 <img> needs to be on a new line. <img> needs to be on a new line. Joao da Silva 2012/07/03 13:39:52 Done. Show quoted text On 2012/07/02 15:56:06, James Hawkins wrote: > <img> needs to be on a new line. Done.
	147 height="100%" alt="background" onmousedown="return false;"/></div>
	James Hawkins 2012/07/02 15:56:06 nit: </div> must be on a new line since the <div> nit: </div> must be on a new line since the <div> line is wrapped. Here and pretty much all of the lines changed in this file in this CL. James Hawkins 2012/07/02 15:56:06 Why do you need to specify the onmousedown here? Why do you need to specify the onmousedown here? Joao da Silva 2012/07/03 13:39:52 Done. Show quoted text On 2012/07/02 15:56:06, James Hawkins wrote: > nit: </div> must be on a new line since the <div> line is wrapped. > > Here and pretty much all of the lines changed in this file in this CL. Done. Joao da Silva 2012/07/03 13:39:52 I honestly don't know why this is here. Please not Show quoted text On 2012/07/02 15:56:06, James Hawkins wrote: > Why do you need to specify the onmousedown here? I honestly don't know why this is here. Please notice that this isn't my code :-) I'm happy to clean it up, but I don't know why much of it is the way it is. Someone probably fixed some bug when this was introduced.
147 <table width="100%" cellspacing="0" cellpadding="0">	148 <table width="100%" cellspacing="0" cellpadding="0">

148 <td class="cell" valign="middle" align="center">	149 <td class="cell" valign="middle" align="center">

149 <div class="box">	150 <div class="box">

150 <div class="icon"><img src="shared/images/phishing_icon.png" alt="Malware Icon" onmousedown="return false;"/></div>	151 <div class="icon"><img src="shared/images/phishing_icon.png"

	152 alt="Malware Icon" onmousedown="return false;"/></div>

151 <div class="title" i18n-content="headLine"></div>	153 <div class="title" i18n-content="headLine"></div>

152 <div class="main" i18n-values=".innerHTML:description1"></div>	154 <div class="main" i18n-values=".innerHTML:description1"></div>

153 <div class="main" i18n-values=".innerHTML:description2"></div>	155 <div class="main" i18n-values=".innerHTML:description2"></div>

154 <div class="main" i18n-values=".innerHTML:description5" id="detailinfo" st yle="display:block"></div>	156 <div class="main" i18n-values=".innerHTML:description5" id="detailinfo"
	James Hawkins 2012/07/02 15:56:06 nit: ID must be the first attribute specified. nit: ID must be the first attribute specified. Joao da Silva 2012/07/03 13:39:52 Done. Show quoted text On 2012/07/02 15:56:06, James Hawkins wrote: > nit: ID must be the first attribute specified. Done.
	157 style="display:block"></div>
	James Hawkins 2012/07/02 15:56:06 <div> is already display: block. <div> is already display: block. Joao da Silva 2012/07/03 13:39:52 Done. Show quoted text On 2012/07/02 15:56:06, James Hawkins wrote: > <div> is already display: block. Done.
155	158

156 <div class="main">	159 <div class="main">

157 <form class="submission">	160 <form class="submission">

158 <input type="button" class="green" id="back" i18n-values="value:back_b utton" onclick="sendCommand('takeMeBack')">	161 <button class="green" id="back" i18n-content="back_button"

	162 onclick="sendCommand('takeMeBack')"></button>

159 <br>	163 <br>

160 </form>	164 </form>

161 </div>	165 </div>

162	166

163 <div class="main" i18n-values=".innerHTML:description3"></div>	167 <div class="main" i18n-values=".innerHTML:description3"

	168 jsdisplay="!proceedDisabled"></div>

164	169

165 <div class="main footer" jsdisplay="displaycheckbox">	170 <div class="main footer" jsdisplay="displaycheckbox">

166 <label class="checkbox" for="checkreport">	171 <label class="checkbox" for="checkreport">

167 <input name="checked" id="checkreport" type="checkbox"	172 <input name="checked" id="checkreport" type="checkbox"

168 jsvalues=".checked:boxchecked" onclick="savePreference()">	173 jsvalues=".checked:boxchecked" onclick="savePreference()">

169 <span i18n-values=".innerHTML:confirm_text"></span>	174 <span i18n-values=".innerHTML:confirm_text"></span>

170 </label>	175 </label>

171 </div>	176 </div>

172	177

173 </div>	178 </div>

174 </td>	179 </td>

175 </table>	180 </table>

176 </body>	181 </body>

177 </html>	182 </html>

OLD	NEW