Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Unified Diff: content/common/child_thread.cc

Issue 10694014: Cleanup IPC::ChannelProxy to use SingleThreadTaskRunner (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/child_thread.cc
diff --git a/content/common/child_thread.cc b/content/common/child_thread.cc
index 3f00f93e120f259a43f9d308c7810df563b551a6..71a40389b91d245d6c42a9cbb76a7341a4a4249e 100644
--- a/content/common/child_thread.cc
+++ b/content/common/child_thread.cc
@@ -75,6 +75,9 @@ ChildThread::~ChildThread() {
// releases the reference count to this channel.
channel_->Close();
+ // TODO(sergeyu): The comment below is not up to date. Figure out if
jam 2012/07/01 22:19:41 no need for the TODO, I'm looking into this :) htt
Sergey Ulanov 2012/07/02 18:44:34 Done.
+ // we still need this call and update the comment or remove it.
+ //
// The ChannelProxy object caches a pointer to the IPC thread, so need to
// reset it as it's not guaranteed to outlive this object.
// NOTE: this also has the side-effect of not closing the main IPC channel to
@@ -83,7 +86,7 @@ ChildThread::~ChildThread() {
// until this process is shut down, and the OS closes the handle
// automatically. We used to watch the object handle on Windows to do this,
// but it wasn't possible to do so on POSIX.
- channel_->ClearIPCMessageLoop();
+ channel_->ClearIPCTaskRunner();
}
void ChildThread::OnChannelError() {

Powered by Google App Engine
This is Rietveld 408576698