Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3605)

Unified Diff: chrome/service/service_ipc_server.cc

Issue 10694014: Cleanup IPC::ChannelProxy to use SingleThreadTaskRunner (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/common/child_thread.cc » ('j') | content/common/child_thread.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/service/service_ipc_server.cc
diff --git a/chrome/service/service_ipc_server.cc b/chrome/service/service_ipc_server.cc
index fc006554a9b7a913932cb75a35d77da19ea09f73..002aeaf900aa01bac9f9b35283c4f050479bc97d 100644
--- a/chrome/service/service_ipc_server.cc
+++ b/chrome/service/service_ipc_server.cc
@@ -40,6 +40,9 @@ ServiceIPCServer::~ServiceIPCServer() {
channel_->RemoveFilter(sync_message_filter_.get());
+ // TODO(sergeyu): The comment below is not up to date. Figure out if
jam 2012/07/01 22:19:41 this code block got copied even though it's not ne
Sergey Ulanov 2012/07/02 18:44:34 Done.
+ // we still need this call and update the comment or remove it.
+ //
// The ChannelProxy object caches a pointer to the IPC thread, so need to
// reset it as it's not guaranteed to outlive this object.
// NOTE: this also has the side-effect of not closing the main IPC channel to
@@ -48,7 +51,7 @@ ServiceIPCServer::~ServiceIPCServer() {
// until this process is shut down, and the OS closes the handle
// automatically. We used to watch the object handle on Windows to do this,
// but it wasn't possible to do so on POSIX.
- channel_->ClearIPCMessageLoop();
+ channel_->ClearIPCTaskRunner();
}
void ServiceIPCServer::OnChannelConnected(int32 peer_pid) {
« no previous file with comments | « no previous file | content/common/child_thread.cc » ('j') | content/common/child_thread.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698