Cleanup IPC::ChannelProxy to use SingleThreadTaskRunner

chrome/service/service_ipc_server.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/service/service_ipc_server.h"
 
 #include "chrome/common/service_messages.h"
 #include "chrome/service/cloud_print/cloud_print_proxy.h"
 #include "chrome/service/service_process.h"
 #include "ipc/ipc_logging.h"
@@ skipping 22 matching lines @@
   channel_->AddFilter(sync_message_filter_.get());
 }
 
 ServiceIPCServer::~ServiceIPCServer() {
 #ifdef IPC_MESSAGE_LOG_ENABLED
   IPC::Logging::GetInstance()->SetIPCSender(NULL);
 #endif
 
   channel_->RemoveFilter(sync_message_filter_.get());
 
+  // TODO(sergeyu): The comment below is not up to date. Figure out if

[jam, 2012/07/01 22:19:41]

this code block got copied even though it's not needed. you can remove it all
(line 43-54)

[Sergey Ulanov, 2012/07/02 18:44:34]

Done.

+  // we still need this call and update the comment or remove it.
+  //
   // The ChannelProxy object caches a pointer to the IPC thread, so need to
   // reset it as it's not guaranteed to outlive this object.
   // NOTE: this also has the side-effect of not closing the main IPC channel to
   // the browser process.  This is needed because this is the signal that the
   // browser uses to know that this process has died, so we need it to be alive
   // until this process is shut down, and the OS closes the handle
   // automatically.  We used to watch the object handle on Windows to do this,
   // but it wasn't possible to do so on POSIX.
-  channel_->ClearIPCMessageLoop();
+  channel_->ClearIPCTaskRunner();
 }
 
 void ServiceIPCServer::OnChannelConnected(int32 peer_pid) {
   DCHECK(!client_connected_);
   client_connected_ = true;
 }
 
 void ServiceIPCServer::OnChannelError() {
   // When a client (typically a browser process) disconnects, the pipe is
   // closed and we get an OnChannelError. Since we want to keep servicing
@@ skipping 92 matching lines @@
 }
 
 void ServiceIPCServer::OnEnableVirtualDriver() {
   g_service_process->EnableVirtualPrintDriver();
 }
 
 void ServiceIPCServer::OnDisableVirtualDriver() {
   g_service_process->DisableVirtualPrintDriver();
 }