Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issue 10693064: Make file chooser work when DevTools window is docked to the inspected tab (Closed)

Created:
8 years, 5 months ago by yurys
Modified:
8 years, 5 months ago
Reviewers:
alexeif, pfeldman, loislo
CC:
chromium-reviews
Visibility:
Public.

Description

Make file chooser work when DevTools window is docked to the inspected tab BUG=128176 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145272

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M chrome/browser/debugger/devtools_window.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/debugger/devtools_window.cc View 3 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
yurys
8 years, 5 months ago (2012-07-02 14:00:31 UTC) #1
pfeldman
lgtm
8 years, 5 months ago (2012-07-02 15:00:49 UTC) #2
pfeldman
lgtm
8 years, 5 months ago (2012-07-02 15:00:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/10693064/1
8 years, 5 months ago (2012-07-02 15:01:39 UTC) #4
commit-bot: I haz the power
Try job failure for 10693064-1 (retry) on linux_rel for step "interactive_ui_tests". It's a second try, ...
8 years, 5 months ago (2012-07-02 15:38:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/10693064/1
8 years, 5 months ago (2012-07-03 08:13:54 UTC) #6
commit-bot: I haz the power
8 years, 5 months ago (2012-07-03 09:30:43 UTC) #7
Change committed as 145272

Powered by Google App Engine
This is Rietveld 408576698