Enhance chrome://omnibox Presentation

chrome/browser/ui/webui/omnibox/omnibox_ui_handler.cc

Index: chrome/browser/ui/webui/omnibox/omnibox_ui_handler.cc
===================================================================
--- chrome/browser/ui/webui/omnibox/omnibox_ui_handler.cc	(revision 148107)
+++ chrome/browser/ui/webui/omnibox/omnibox_ui_handler.cc	(working copy)
@@ -125,6 +125,9 @@
     output->SetString(item_prefix + ".keyword", it->keyword);
     output->SetBoolean(item_prefix + ".starred", it->starred);
     output->SetBoolean(item_prefix + ".from_previous", it->from_previous);
+    for (std::map<std::string, std::string>::const_iterator j =
+         it->diagnostics.begin(); j != it->diagnostics.end(); ++j)

[Evan Stade, 2012/07/26 03:56:21]

curlies

[Peter Kasting, 2012/07/26 05:25:43]

Not necessary (and I discourage them), since the body is one line.

[Evan Stade, 2012/07/27 00:04:42]

I don't like that rule for loops, and the style guide seems to recommend curlies
here:

"curly braces are not required for single-line statements, but they are allowed
if you like them; conditional or loop statements with complex conditions or
statements may be more readable with curly braces"

[mrossetti, 2012/07/27 17:55:36]

Done.

+      output->SetString(item_prefix + ".diagnostics." + j->first, j->second);
   }
   output->SetInteger(prefix + ".num_items", i);
 }