Enhance chrome://omnibox Presentation

chrome/browser/ui/webui/omnibox/omnibox_ui_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/omnibox/omnibox_ui_handler.h"
 
 #include <string>
 
 #include "base/bind.h"
 #include "base/string16.h"
@@ skipping 107 matching lines @@
                        it->is_history_what_you_typed_match);
     output->SetString(item_prefix + ".type",
                       AutocompleteMatch::TypeToString(it->type));
     if (it->associated_keyword.get() != NULL) {
       output->SetString(item_prefix + ".associated_keyword",
                         it->associated_keyword->keyword);
     }
     output->SetString(item_prefix + ".keyword", it->keyword);
     output->SetBoolean(item_prefix + ".starred", it->starred);
     output->SetBoolean(item_prefix + ".from_previous", it->from_previous);
+    for (std::map<std::string, std::string>::const_iterator j =
+         it->diagnostics.begin(); j != it->diagnostics.end(); ++j)

[Evan Stade, 2012/07/26 03:56:21]

curlies

[Peter Kasting, 2012/07/26 05:25:43]

Not necessary (and I discourage them), since the body is one line.

[Evan Stade, 2012/07/27 00:04:42]

I don't like that rule for loops, and the style guide seems to recommend curlies
here:

"curly braces are not required for single-line statements, but they are allowed
if you like them; conditional or loop statements with complex conditions or
statements may be more readable with curly braces"

[mrossetti, 2012/07/27 17:55:36]

Done.

+      output->SetString(item_prefix + ".diagnostics." + j->first, j->second);
   }
   output->SetInteger(prefix + ".num_items", i);
 }
 
 void OmniboxUIHandler::StartOmniboxQuery(
     const base::ListValue* one_element_input_string) {
   string16 input_string = ExtractStringValue(one_element_input_string);
   string16 empty_string;
   // Tell the autocomplete controller to start working on the
   // input.  It's okay if the previous request hasn't yet finished;
   // the autocomplete controller is smart enough to stop the previous
   // query before it starts the new one.  By the way, in this call to
   // Start(), we use the default/typical values for all parameters.
   time_omnibox_started_ = base::Time::Now();
   controller_->Start(input_string,
                      empty_string,  // user's desired tld (top-level domain)
                      false,  // don't prevent inline autocompletion
                      false,  // no preferred keyword provider
                      true,  // allow exact keyword matches
                      AutocompleteInput::ALL_MATCHES);  // want all matches
 }