Issue 10692021: Remove browser::FindLastActiveWithProfile call in login_ui_service.cc by plumbing the Browser* thro…

Issue 10692021: Remove browser::FindLastActiveWithProfile call in login_ui_service.cc by plumbing the Browser* thro… (Closed)

Created:
8 years, 5 months ago by jam

Modified:
8 years, 5 months ago

Reviewers:
Andrew T Wilson (Slow)

CC:
chromium-reviews, Raghu Simha, ncarter (slow), akalin, tim (not reviewing)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Remove browser::FindLastActiveWithProfile call in login_ui_service.cc by plumbing the Browser* through. BUG=129187 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=144611

Patch Set 2 : #

Total comments: 5

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -52 lines)			Patch
M	chrome/browser/sync/sync_global_error.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/sync/sync_global_error_unittest.cc	View	1	2 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/chrome_pages.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/sync/one_click_signin_helper.cc	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/sync/one_click_signin_sync_starter.h	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/sync/one_click_signin_sync_starter.cc	View		4 chunks	+12 lines, -9 lines	0 comments	Download
M	chrome/browser/ui/webui/signin/login_ui_service.h	View		3 chunks	+4 lines, -10 lines	5 comments	Download
M	chrome/browser/ui/webui/signin/login_ui_service.cc	View	1	3 chunks	+3 lines, -17 lines	0 comments	Download
M	chrome/browser/ui/webui/signin/login_ui_service_factory.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jam

http://codereview.chromium.org/10692021/diff/10001/chrome/browser/ui/webui/signin/login_ui_service.h File chrome/browser/ui/webui/signin/login_ui_service.h (left): http://codereview.chromium.org/10692021/diff/10001/chrome/browser/ui/webui/signin/login_ui_service.h#oldcode34 chrome/browser/ui/webui/signin/login_ui_service.h:34: // when no browser windows are open (e.g. via ...

8 years, 5 months ago (2012-06-27 21:43:27 UTC) #2

Andrew T Wilson (Slow)

LGTM http://codereview.chromium.org/10692021/diff/10001/chrome/browser/ui/webui/signin/login_ui_service.h File chrome/browser/ui/webui/signin/login_ui_service.h (right): http://codereview.chromium.org/10692021/diff/10001/chrome/browser/ui/webui/signin/login_ui_service.h#newcode32 chrome/browser/ui/webui/signin/login_ui_service.h:32: // Creates a LoginUIService Remove this comment since ...

8 years, 5 months ago (2012-06-27 22:32:36 UTC) #3

jam

8 years, 5 months ago (2012-06-27 22:39:30 UTC) #4

http://codereview.chromium.org/10692021/diff/10001/chrome/browser/ui/webui/si...
File chrome/browser/ui/webui/signin/login_ui_service.h (right):

http://codereview.chromium.org/10692021/diff/10001/chrome/browser/ui/webui/si...
chrome/browser/ui/webui/signin/login_ui_service.h:32: // Creates a
LoginUIService
On 2012/06/27 22:32:36, Andrew T Wilson wrote:
> Remove this comment since it adds nothing?

Done.

http://codereview.chromium.org/10692021/diff/10001/chrome/browser/ui/webui/si...
chrome/browser/ui/webui/signin/login_ui_service.h:50: // navigates to the login
UI page in a new browser tab.
On 2012/06/27 22:32:36, Andrew T Wilson wrote:
> Update this comment, since it sounds like we use the passed browser?

Done.

Expand Messages | Collapse Messages