Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4359)

Unified Diff: chrome/browser/sync/sync_global_error_unittest.cc

Issue 10692021: Remove browser::FindLastActiveWithProfile call in login_ui_service.cc by plumbing the Browser* thro… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/sync_global_error_unittest.cc
===================================================================
--- chrome/browser/sync/sync_global_error_unittest.cc (revision 144404)
+++ chrome/browser/sync/sync_global_error_unittest.cc (working copy)
@@ -38,12 +38,12 @@
class LoginUIServiceMock: public LoginUIService {
public:
- explicit LoginUIServiceMock(Profile* profile) : LoginUIService(profile) {}
- MOCK_METHOD0(ShowLoginUI, void());
+ explicit LoginUIServiceMock() : LoginUIService() {}
+ MOCK_METHOD1(ShowLoginUI, void(Browser*));
};
ProfileKeyedService* BuildMockLoginUIService(Profile* profile) {
- return new LoginUIServiceMock(profile);
+ return new LoginUIServiceMock();
}
// Same as BrowserWithTestWindowTest, but uses MockBrowser to test calls to
@@ -114,9 +114,9 @@
#else
// Test message handler.
if (is_error) {
- EXPECT_CALL(*login_ui_service, ShowLoginUI());
+ EXPECT_CALL(*login_ui_service, ShowLoginUI(browser));
error->ExecuteMenuItem(browser);
- EXPECT_CALL(*login_ui_service, ShowLoginUI());
+ EXPECT_CALL(*login_ui_service, ShowLoginUI(browser));
error->BubbleViewAcceptButtonPressed(browser);
error->BubbleViewDidClose(browser);
}

Powered by Google App Engine
This is Rietveld 408576698