Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10690151: Move implementation of BrowserList onto an inner, instantiatable class, BrowserListImpl. (Closed)

Created:
8 years, 5 months ago by Ben Goodger (Google)
Modified:
8 years, 5 months ago
Reviewers:
tfarina, jam
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, tfarina, kkania, Aaron Boodman, rginda+watch_chromium.org, robertshield
Visibility:
Public.

Description

Move implementation of BrowserList onto an inner, instantiatable class, BrowserListImpl. This is so we can create one BrowserListImpl per universe. Eventually we'll get rid of BrowserList, but for now this change strives for compat. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=146476

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+580 lines, -305 lines) Patch
M chrome/browser/automation/testing_automation_provider.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chrome_browser_main.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager_util.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/web_navigation/web_navigation_api.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/web_navigation/web_navigation_api.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/bundle_installer.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/bundle_installer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_browser_event_router.h View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_browser_event_router.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/importer/importer_host.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/importer/importer_host.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/managed_mode.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/managed_mode.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/page_cycler/page_cycler.h View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/page_cycler/page_cycler.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/page_cycler/page_cycler_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/profiles/profile_manager.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/protector/settings_change_global_error.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/protector/settings_change_global_error.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/browser_close_browsertest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/browser_list.h View 3 chunks +3 lines, -22 lines 0 comments Download
M chrome/browser/ui/browser_list.cc View 1 chunk +21 lines, -248 lines 0 comments Download
A chrome/browser/ui/browser_list_impl.h View 1 2 1 chunk +94 lines, -0 lines 0 comments Download
A chrome/browser/ui/browser_list_impl.cc View 1 2 1 chunk +206 lines, -0 lines 0 comments Download
A chrome/browser/ui/browser_list_observer.h View 1 1 chunk +31 lines, -0 lines 2 comments Download
M chrome/browser/ui/cocoa/profile_menu_controller.mm View 3 chunks +3 lines, -2 lines 0 comments Download
A chrome/browser/ui/host_desktop.h View 1 chunk +34 lines, -0 lines 0 comments Download
M chrome/browser/ui/network_profile_bubble.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_browsertest.cc View 2 chunks +2 lines, -1 line 0 comments Download
A chrome/browser/ui/uma_browsing_activity_observer.h View 1 chunk +45 lines, -0 lines 0 comments Download
A chrome/browser/ui/uma_browsing_activity_observer.cc View 1 chunk +88 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Ben Goodger (Google)
8 years, 5 months ago (2012-07-11 23:06:03 UTC) #1
jam
lgtm http://codereview.chromium.org/10690151/diff/1/chrome/browser/ui/browser_list.cc File chrome/browser/ui/browser_list.cc (right): http://codereview.chromium.org/10690151/diff/1/chrome/browser/ui/browser_list.cc#newcode10 chrome/browser/ui/browser_list.cc:10: #include "chrome/browser/ui/browser_list_observer.h" this file isn't part of the ...
8 years, 5 months ago (2012-07-12 18:53:22 UTC) #2
tfarina
8 years, 5 months ago (2012-07-13 00:55:22 UTC) #3 
http://codereview.chromium.org/10690151/diff/14005/chrome/browser/ui/browser_...
File chrome/browser/ui/browser_list_observer.h (right):

http://codereview.chromium.org/10690151/diff/14005/chrome/browser/ui/browser_...
chrome/browser/ui/browser_list_observer.h:1: // Copyright (c) 2012 The Chromium
Authors. All rights reserved.
Thanks for doing this! Although I had a patch in my branch here to extract
BrowserListObserver from BrowserList, but never had time to send to you :-(

http://codereview.chromium.org/10690151/diff/14005/chrome/browser/ui/browser_...
chrome/browser/ui/browser_list_observer.h:15: public:
nit: indent one less space ;)

Powered by Google App Engine
This is Rietveld 408576698