Issue 10690126: gdata: Use member functions of CacheEntry where it can

Issue 10690126: gdata: Use member functions of CacheEntry where it can (Closed)

Created:
8 years, 5 months ago by satorux1

Modified:
8 years, 5 months ago

Reviewers:
achuithb, hshi1

CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, nkostylev+watch_chromium.org, achuith+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

gdata: Use member functions of CacheEntry where it can BUG=136625 TEST=out/Release/unit_tests --gtest_filter=GData* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=146059

Patch Set 1 #

Patch Set 2 : polish #

Total comments: 2

Patch Set 3 : address commentx #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -20 lines)			Patch
M	chrome/browser/chromeos/extensions/file_browser_private_api.cc	View	1 2	1 chunk	+7 lines, -14 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_cache.h	View	1 2	2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_cache.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

hshi1

LGTM with one nit, thanks! https://chromiumcodereview.appspot.com/10690126/diff/1004/chrome/browser/chromeos/gdata/gdata_cache.h File chrome/browser/chromeos/gdata/gdata_cache.h (right): https://chromiumcodereview.appspot.com/10690126/diff/1004/chrome/browser/chromeos/gdata/gdata_cache.h#newcode153 chrome/browser/chromeos/gdata/gdata_cache.h:153: // |set to CACHE_STATE_NONE. ...

8 years, 5 months ago (2012-07-10 23:54:49 UTC) #3

satorux1

http://codereview.chromium.org/10690126/diff/1004/chrome/browser/chromeos/gdata/gdata_cache.h File chrome/browser/chromeos/gdata/gdata_cache.h (right): http://codereview.chromium.org/10690126/diff/1004/chrome/browser/chromeos/gdata/gdata_cache.h#newcode153 chrome/browser/chromeos/gdata/gdata_cache.h:153: // |set to CACHE_STATE_NONE. On 2012/07/10 23:54:49, hshi1 wrote: ...

8 years, 5 months ago (2012-07-11 05:24:58 UTC) #5

hshi1

8 years, 5 months ago (2012-07-11 05:48:26 UTC) #6

On 2012/07/11 05:24:58, satorux1 wrote:
>
http://codereview.chromium.org/10690126/diff/1004/chrome/browser/chromeos/gda...
> File chrome/browser/chromeos/gdata/gdata_cache.h (right):
> 
>
http://codereview.chromium.org/10690126/diff/1004/chrome/browser/chromeos/gda...
> chrome/browser/chromeos/gdata/gdata_cache.h:153: // |set to CACHE_STATE_NONE.
> On 2012/07/10 23:54:49, hshi1 wrote:
> > Nit: remove extra character '|' before "set".
> 
> Done.

LGTM.

Expand Messages | Collapse Messages