gdata: Use member functions of CacheEntry where it can

chrome/browser/chromeos/gdata/gdata_cache.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_GDATA_GDATA_CACHE_H_
 #define CHROME_BROWSER_CHROMEOS_GDATA_GDATA_CACHE_H_
 #pragma once
 
 #include <map>
 #include <string>
@@ skipping 103 matching lines @@
 
     // Triggered when a dirty file has been committed (saved) successfully.
     virtual void OnCacheCommitted(const std::string& resource_id) {}
 
    protected:
     virtual ~Observer() {}
   };
 
   // Structure to store information of an existing cache file.
   struct CacheEntry {
-    CacheEntry() : cache_state(0) {}
+    CacheEntry() : cache_state(CACHE_STATE_NONE) {}
 
     CacheEntry(const std::string& md5,
                int cache_state)
         : md5(md5),
           cache_state(cache_state) {
     }
 
     bool IsPresent() const { return IsCachePresent(cache_state); }
     bool IsPinned() const { return IsCachePinned(cache_state); }
     bool IsDirty() const { return IsCacheDirty(cache_state); }
     bool IsMounted() const { return IsCacheMounted(cache_state); }
     bool IsPersistent() const { return IsCachePersistent(cache_state); }
 
     // Returns the type of the sub directory where the cache file is stored.
     CacheSubDirectoryType GetSubDirectoryType() const {
       return IsPersistent() ? CACHE_TYPE_PERSISTENT : CACHE_TYPE_TMP;
     }
 
     // For debugging purposes.
     std::string ToString() const;
 
     std::string md5;
     int cache_state;
   };
 
   // Callback for GetCacheEntryOnUIThread.
   // |success| indicates if the operation was successful.
-  // |cache_entry| is the obtained cache entry.
+  // |cache_entry| is the obtained cache entry. On failure, |cache_state| is
+  // |set to CACHE_STATE_NONE.

[hshi1, 2012/07/10 23:54:49]

Nit: remove extra character '|' before "set".

[satorux1, 2012/07/11 05:24:58]

Done.

   //
   // TODO(satorux): Unlike other callback types, this has to be defined
   // inside GDataCache as CacheEntry is inside GDataCache. We should get them
   // outside of GDataCache.
   typedef base::Callback<void(bool success, const CacheEntry& cache_entry)>
       GetCacheEntryCallback;
 
   static bool IsCachePresent(int cache_state) {
     return cache_state & CACHE_STATE_PRESENT;
   }
@@ skipping 362 matching lines @@
 };
 
 // Sets the free disk space getter for testing.
 // The existing getter is deleted.
 void SetFreeDiskSpaceGetterForTesting(
     FreeDiskSpaceGetterInterface* getter);
 
 }  // namespace gdata
 
 #endif  // CHROME_BROWSER_CHROMEOS_GDATA_GDATA_CACHE_H_