Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(707)

Unified Diff: net/spdy/spdy_proxy_client_socket_spdy2_unittest.cc

Issue 10690104: DeterministicSocketDataProvider should not be RefCounted (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: One more leak fix Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/spdy/spdy_proxy_client_socket_spdy2_unittest.cc
diff --git a/net/spdy/spdy_proxy_client_socket_spdy2_unittest.cc b/net/spdy/spdy_proxy_client_socket_spdy2_unittest.cc
index a8eabde3f74304a352b3d1199a417e2ace8ab1ed..9d149fbba6a9405c3b752fdbd76e50f517163378 100644
--- a/net/spdy/spdy_proxy_client_socket_spdy2_unittest.cc
+++ b/net/spdy/spdy_proxy_client_socket_spdy2_unittest.cc
@@ -110,7 +110,7 @@ class SpdyProxyClientSocketSpdy2Test : public PlatformTest {
scoped_ptr<SpdyProxyClientSocket> sock_;
TestCompletionCallback read_callback_;
TestCompletionCallback write_callback_;
- scoped_refptr<DeterministicSocketData> data_;
+ scoped_ptr<DeterministicSocketData> data_;
private:
scoped_refptr<HttpNetworkSession> session_;
@@ -170,7 +170,8 @@ void SpdyProxyClientSocketSpdy2Test::Initialize(MockRead* reads,
size_t reads_count,
MockWrite* writes,
size_t writes_count) {
- data_ = new DeterministicSocketData(reads, reads_count, writes, writes_count);
+ data_.reset(new DeterministicSocketData(reads, reads_count,
+ writes, writes_count));
data_->set_connect_data(connect_data_);
data_->SetStop(2);
« no previous file with comments | « net/spdy/spdy_network_transaction_spdy3_unittest.cc ('k') | net/spdy/spdy_proxy_client_socket_spdy3_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698