Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1608)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/spdy/spdy_network_transaction_spdy3_unittest.cc

Issue 10690104: DeterministicSocketDataProvider should not be RefCounted (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: One more leak fix Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/spdy_network_transaction_spdy2_unittest.cc ('k') | net/spdy/spdy_proxy_client_socket_spdy2_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_network_transaction_spdy3_unittest.cc
diff --git a/net/spdy/spdy_network_transaction_spdy3_unittest.cc b/net/spdy/spdy_network_transaction_spdy3_unittest.cc
index 4eca577d18eed7e27d451e4c65ce983b9229e8fc..975285e05d9d64478e2550d7a54aefd7e1cfc466 100644
--- a/net/spdy/spdy_network_transaction_spdy3_unittest.cc
+++ b/net/spdy/spdy_network_transaction_spdy3_unittest.cc
@@ -232,24 +232,24 @@ class SpdyNetworkTransactionSpdy3Test
void AddData(StaticSocketDataProvider* data) {
DCHECK(!deterministic_);
data_vector_.push_back(data);
- linked_ptr<SSLSocketDataProvider> ssl_(
- new SSLSocketDataProvider(ASYNC, OK));
- if (test_type_ == SPDYNPN) {
- ssl_->SetNextProto(kProtoSPDY3);
- }
- ssl_vector_.push_back(ssl_);
+ SSLSocketDataProvider* ssl_provider =
+ new SSLSocketDataProvider(ASYNC, OK);
+ if (test_type_ == SPDYNPN)
+ ssl_provider->SetNextProto(kProtoSPDY3);
+
+ ssl_vector_.push_back(ssl_provider);
if (test_type_ == SPDYNPN || test_type_ == SPDYSSL)
- session_deps_->socket_factory->AddSSLSocketDataProvider(ssl_.get());
+ session_deps_->socket_factory->AddSSLSocketDataProvider(ssl_provider);
+
session_deps_->socket_factory->AddSocketDataProvider(data);
if (test_type_ == SPDYNPN) {
MockConnect never_finishing_connect(SYNCHRONOUS, ERR_IO_PENDING);
- linked_ptr<StaticSocketDataProvider>
- hanging_non_alternate_protocol_socket(
- new StaticSocketDataProvider(NULL, 0, NULL, 0));
+ StaticSocketDataProvider* hanging_non_alternate_protocol_socket =
+ new StaticSocketDataProvider(NULL, 0, NULL, 0);
hanging_non_alternate_protocol_socket->set_connect_data(
never_finishing_connect);
session_deps_->socket_factory->AddSocketDataProvider(
- hanging_non_alternate_protocol_socket.get());
+ hanging_non_alternate_protocol_socket);
alternate_vector_.push_back(hanging_non_alternate_protocol_socket);
}
}
@@ -257,22 +257,21 @@ class SpdyNetworkTransactionSpdy3Test
void AddDeterministicData(DeterministicSocketData* data) {
DCHECK(deterministic_);
data_vector_.push_back(data);
- linked_ptr<SSLSocketDataProvider> ssl_(
- new SSLSocketDataProvider(ASYNC, OK));
- if (test_type_ == SPDYNPN) {
- ssl_->SetNextProto(kProtoSPDY3);
- }
- ssl_vector_.push_back(ssl_);
+ SSLSocketDataProvider* ssl_provider =
+ new SSLSocketDataProvider(ASYNC, OK);
+ if (test_type_ == SPDYNPN)
+ ssl_provider->SetNextProto(kProtoSPDY3);
+
+ ssl_vector_.push_back(ssl_provider);
if (test_type_ == SPDYNPN || test_type_ == SPDYSSL) {
session_deps_->deterministic_socket_factory->
- AddSSLSocketDataProvider(ssl_.get());
+ AddSSLSocketDataProvider(ssl_provider);
}
session_deps_->deterministic_socket_factory->AddSocketDataProvider(data);
if (test_type_ == SPDYNPN) {
MockConnect never_finishing_connect(SYNCHRONOUS, ERR_IO_PENDING);
- scoped_refptr<DeterministicSocketData>
- hanging_non_alternate_protocol_socket(
- new DeterministicSocketData(NULL, 0, NULL, 0));
+ DeterministicSocketData* hanging_non_alternate_protocol_socket =
+ new DeterministicSocketData(NULL, 0, NULL, 0);
hanging_non_alternate_protocol_socket->set_connect_data(
never_finishing_connect);
session_deps_->deterministic_socket_factory->AddSocketDataProvider(
@@ -282,17 +281,6 @@ class SpdyNetworkTransactionSpdy3Test
}
}
- // This can only be called after RunPreTestSetup. It adds a Data Provider,
- // but not a corresponding SSL data provider
- void AddDataNoSSL(StaticSocketDataProvider* data) {
- DCHECK(!deterministic_);
- session_deps_->socket_factory->AddSocketDataProvider(data);
- }
- void AddDataNoSSL(DeterministicSocketData* data) {
- DCHECK(deterministic_);
- session_deps_->deterministic_socket_factory->AddSocketDataProvider(data);
- }
-
void SetSession(const scoped_refptr<HttpNetworkSession>& session) {
session_ = session;
}
@@ -313,10 +301,9 @@ class SpdyNetworkTransactionSpdy3Test
private:
typedef std::vector<StaticSocketDataProvider*> DataVector;
- typedef std::vector<linked_ptr<SSLSocketDataProvider> > SSLVector;
- typedef std::vector<linked_ptr<StaticSocketDataProvider> > AlternateVector;
- typedef std::vector<scoped_refptr<DeterministicSocketData> >
- AlternateDeterministicVector;
+ typedef ScopedVector<SSLSocketDataProvider> SSLVector;
+ typedef ScopedVector<StaticSocketDataProvider> AlternateVector;
+ typedef ScopedVector<DeterministicSocketData> AlternateDeterministicVector;
HttpRequestInfo request_;
scoped_ptr<SpdySessionDependencies> session_deps_;
scoped_refptr<HttpNetworkSession> session_;
@@ -1782,7 +1769,7 @@ TEST_P(SpdyNetworkTransactionSpdy3Test, SocketWriteReturnsZero) {
MockRead(ASYNC, 0, 0, 4) // EOF
};
- scoped_refptr<DeterministicSocketData> data(
+ scoped_ptr<DeterministicSocketData> data(
new DeterministicSocketData(reads, arraysize(reads),
writes, arraysize(writes)));
NormalSpdyTransactionHelper helper(CreateGetRequest(),
@@ -2552,7 +2539,7 @@ TEST_P(SpdyNetworkTransactionSpdy3Test, CancelledTransactionSendRst) {
MockRead(ASYNC, 0, 0, 3) // EOF
};
- scoped_refptr<DeterministicSocketData> data(
+ scoped_ptr<DeterministicSocketData> data(
new DeterministicSocketData(reads, arraysize(reads),
writes, arraysize(writes)));
@@ -5565,16 +5552,14 @@ TEST_P(SpdyNetworkTransactionSpdy3Test, ServerPushClaimBeforeHeaders) {
HttpResponseInfo response;
HttpResponseInfo response2;
std::string expected_push_result("pushed");
- scoped_refptr<DeterministicSocketData> data(new DeterministicSocketData(
- reads,
- arraysize(reads),
- writes,
- arraysize(writes)));
+ scoped_ptr<DeterministicSocketData> data(
+ new DeterministicSocketData(reads, arraysize(reads),
+ writes, arraysize(writes)));
NormalSpdyTransactionHelper helper(CreateGetRequest(),
BoundNetLog(), GetParam(), NULL);
helper.SetDeterministic();
- helper.AddDeterministicData(static_cast<DeterministicSocketData*>(data));
+ helper.AddDeterministicData(data.get());
helper.RunPreTestSetup();
HttpNetworkTransaction* trans = helper.trans();
@@ -5608,7 +5593,7 @@ TEST_P(SpdyNetworkTransactionSpdy3Test, ServerPushClaimBeforeHeaders) {
ReadResult(trans2.get(), data.get(), &result2);
// Read the response body.
std::string result;
- ReadResult(trans, data, &result);
+ ReadResult(trans, data.get(), &result);
// Verify that we consumed all test data.
EXPECT_TRUE(data->at_read_eof());
@@ -5717,16 +5702,14 @@ TEST_P(SpdyNetworkTransactionSpdy3Test, ServerPushWithTwoHeaderFrames) {
HttpResponseInfo response;
HttpResponseInfo response2;
std::string expected_push_result("pushed");
- scoped_refptr<DeterministicSocketData> data(new DeterministicSocketData(
- reads,
- arraysize(reads),
- writes,
- arraysize(writes)));
+ scoped_ptr<DeterministicSocketData> data(
+ new DeterministicSocketData(reads, arraysize(reads),
+ writes, arraysize(writes)));
NormalSpdyTransactionHelper helper(CreateGetRequest(),
BoundNetLog(), GetParam(), NULL);
helper.SetDeterministic();
- helper.AddDeterministicData(static_cast<DeterministicSocketData*>(data));
+ helper.AddDeterministicData(data.get());
helper.RunPreTestSetup();
HttpNetworkTransaction* trans = helper.trans();
@@ -5757,10 +5740,10 @@ TEST_P(SpdyNetworkTransactionSpdy3Test, ServerPushWithTwoHeaderFrames) {
// Read the server push body.
std::string result2;
- ReadResult(trans2.get(), data, &result2);
+ ReadResult(trans2.get(), data.get(), &result2);
// Read the response body.
std::string result;
- ReadResult(trans, data, &result);
+ ReadResult(trans, data.get(), &result);
// Verify that we consumed all test data.
EXPECT_TRUE(data->at_read_eof());
@@ -6174,7 +6157,7 @@ TEST_P(SpdyNetworkTransactionSpdy3Test, OutOfOrderSynStream) {
MockRead(ASYNC, 0, 9) // EOF
};
- scoped_refptr<DeterministicSocketData> data(
+ scoped_ptr<DeterministicSocketData> data(
new DeterministicSocketData(reads, arraysize(reads),
writes, arraysize(writes)));
NormalSpdyTransactionHelper helper(CreateGetRequest(),
« no previous file with comments | « net/spdy/spdy_network_transaction_spdy2_unittest.cc ('k') | net/spdy/spdy_proxy_client_socket_spdy2_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698