Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2019)

Unified Diff: content/renderer/media/mock_media_stream_dependency_factory.cc

Issue 10689180: Rolling libjingle to 158:159 (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/mock_media_stream_dependency_factory.cc
===================================================================
--- content/renderer/media/mock_media_stream_dependency_factory.cc (revision 146359)
+++ content/renderer/media/mock_media_stream_dependency_factory.cc (working copy)
@@ -177,6 +177,10 @@
NOTIMPLEMENTED();
return "";
}
+ // TODO(perkj): Implement type().
Sergey Ulanov 2012/07/13 01:22:48 Many other methods in this class are marked as NOT
Ronghua Wu (Left Chromium) 2012/07/13 18:26:35 Not sure about the history, those may not needed b
Sergey Ulanov 2012/07/13 21:06:24 Ok, maybe need to open a bug for this?
Ronghua Wu (Left Chromium) 2012/07/14 00:06:41 Created crbug/137318 for Per.
+ virtual SdpType type() const OVERRIDE {
+ return kOffer;
Sergey Ulanov 2012/07/13 01:22:48 add NOTIMPLEMENTED().
Ronghua Wu (Left Chromium) 2012/07/14 00:06:41 NOTIMPLEMENTED is already added in the last patch.
+ }
virtual bool AddCandidate(const IceCandidateInterface* candidate) OVERRIDE {
NOTIMPLEMENTED();
return false;

Powered by Google App Engine
This is Rietveld 408576698