Rolling libjingle to 158:159

content/renderer/media/mock_media_stream_dependency_factory.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/logging.h"
 #include "content/renderer/media/mock_media_stream_dependency_factory.h"
 #include "content/renderer/media/mock_peer_connection_impl.h"
 #include "third_party/libjingle/source/talk/app/webrtc/mediastreaminterface.h"
 #include "third_party/libjingle/source/talk/base/scoped_ref_ptr.h"
 
@@ skipping 159 matching lines @@
     return NULL;
   }
   virtual std::string session_id() const OVERRIDE {
     NOTIMPLEMENTED();
     return "";
   }
   virtual std::string session_version() const OVERRIDE {
     NOTIMPLEMENTED();
     return "";
   }
+  // TODO(perkj): Implement type().

[Sergey Ulanov, 2012/07/13 01:22:48]

Many other methods in this class are marked as NOTIMPLEMETED()? Is this method
exceptional in any way so we need TODO for it but not for other methods?

[Ronghua Wu (Left Chromium), 2012/07/13 18:26:35]

Not sure about the history, those may not needed by the tests. But the one just
added should be implemented for the testing.

[Sergey Ulanov, 2012/07/13 21:06:24]

Ok, maybe need to open a bug for this?

[Ronghua Wu (Left Chromium), 2012/07/14 00:06:41]

Created crbug/137318 for Per.

+  virtual SdpType type() const OVERRIDE {
+    return kOffer;

[Sergey Ulanov, 2012/07/13 01:22:48]

add NOTIMPLEMENTED().

[Ronghua Wu (Left Chromium), 2012/07/14 00:06:41]

NOTIMPLEMENTED is already added in the last patch.

+  }
   virtual bool AddCandidate(const IceCandidateInterface* candidate) OVERRIDE {
     NOTIMPLEMENTED();
     return false;
   }
   virtual size_t number_of_mediasections() const OVERRIDE {
     NOTIMPLEMENTED();
     return 0;
   }
   virtual const IceCandidateCollection* candidates(
       size_t mediasection_index) const OVERRIDE {
@@ skipping 112 matching lines @@
     const std::string& sdp) {
   return new webrtc::MockSessionDescription(sdp);
 }
 
 webrtc::IceCandidateInterface*
 MockMediaStreamDependencyFactory::CreateIceCandidate(
     const std::string& label,
     const std::string& sdp) {
   return new webrtc::MockIceCandidate(label, sdp);
 }