Enforce the 'requirements' field in manifests.

chrome/browser/extensions/crx_installer.h

Index: chrome/browser/extensions/crx_installer.h
diff --git a/chrome/browser/extensions/crx_installer.h b/chrome/browser/extensions/crx_installer.h
index 1cad3601bc61cfb936cb19036510cc23d3db9082..7931d30e21d4ecd7f0dd1564b8d2bddb339d2035 100644
--- a/chrome/browser/extensions/crx_installer.h
+++ b/chrome/browser/extensions/crx_installer.h
@@ -25,6 +25,7 @@ class SkBitmap;
 
 namespace extensions {
 class ExtensionUpdaterTest;
+class RequirementsChecker;
 
 // This class installs a crx file into a profile.
 //
@@ -165,6 +166,10 @@ class CrxInstaller
     page_ordinal_ = page_ordinal;
   }
 
+  void set_error_on_unsported_requirements(bool val) {
+    error_on_unsported_requirements_ = val;
+  }
+
   bool did_handle_successfully() const { return did_handle_successfully_; }
 
   Profile* profile() { return profile_; }
@@ -199,6 +204,11 @@ class CrxInstaller
   // whitelisted.
   bool CanSkipConfirmation();
 
+  void RunRequirementsChecker();

[Aaron Boodman, 2012/08/01 03:58:54]

Needs comments.

[Yoyo Zhou, 2012/08/02 22:23:30]

How about "Check Requirements"?

[eaugusti, 2012/08/03 01:06:26]

Done.

+
+  // Runs on the FILE thread. Callback from RequirementsChecker.
+  void RequirementsChecked(std::vector<std::string> errors);
+
   // Runs on the UI thread. Confirms with the user (via ExtensionInstallPrompt)
   // that it is OK to install this extension.
   void ConfirmInstall();
@@ -339,6 +349,15 @@ class CrxInstaller
   // Whether we should record an oauth2 grant upon successful install.
   bool record_oauth2_grant_;
 
+  // Whether we should produce an error if the manifest declares requirements
+  // that are not met. If false and there is an unmet requirement, the install
+  // will continue but the extension will be distabled.
+  bool error_on_unsported_requirements_;

[Yoyo Zhou, 2012/08/02 22:23:30]

Did you mean 'unsupported'?

[eaugusti, 2012/08/03 01:06:26]

Done.

+
+  scoped_ptr<RequirementsChecker> requirements_checker_;
+
+  std::vector<std::string> requirement_errors_;
+
   DISALLOW_COPY_AND_ASSIGN(CrxInstaller);
 };