Enforce the 'requirements' field in manifests.

chrome/browser/extensions/crx_installer.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_CRX_INSTALLER_H_
 #define CHROME_BROWSER_EXTENSIONS_CRX_INSTALLER_H_
 
 #include <string>
 
 #include "base/compiler_specific.h"
 #include "base/file_path.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/weak_ptr.h"
 #include "base/version.h"
 #include "chrome/browser/extensions/crx_installer_error.h"
 #include "chrome/browser/extensions/extension_install_prompt.h"
 #include "chrome/browser/extensions/sandboxed_unpacker.h"
 #include "chrome/browser/extensions/webstore_installer.h"
 #include "chrome/common/extensions/extension.h"
 #include "chrome/common/string_ordinal.h"
 #include "chrome/common/web_apps.h"
 
 class ExtensionService;
 class SkBitmap;
 
 namespace extensions {
 class ExtensionUpdaterTest;
+class RequirementsChecker;
 
 // This class installs a crx file into a profile.
 //
 // Installing a CRX is a multi-step process, including unpacking the crx,
 // validating it, prompting the user, and installing. Since many of these
 // steps must occur on the file thread, this class contains a copy of all data
 // necessary to do its job. (This also minimizes external dependencies for
 // easier testing).
 //
 // Lifetime management:
@@ skipping 120 matching lines @@
     return off_store_install_allow_reason_;
   }
   void set_off_store_install_allow_reason(OffStoreInstallAllowReason reason) {
     off_store_install_allow_reason_ = reason;
   }
 
   void set_page_ordinal(const StringOrdinal& page_ordinal) {
     page_ordinal_ = page_ordinal;
   }
 
+  void set_error_on_unsported_requirements(bool val) {
+    error_on_unsported_requirements_ = val;
+  }
+
   bool did_handle_successfully() const { return did_handle_successfully_; }
 
   Profile* profile() { return profile_; }
 
  private:
   friend class ExtensionUpdaterTest;
   friend class ExtensionCrxInstallerTest;
 
   CrxInstaller(base::WeakPtr<ExtensionService> frontend_weak,
                ExtensionInstallPrompt* client,
@@ skipping 14 matching lines @@
   virtual void OnUnpackFailure(const string16& error_message) OVERRIDE;
   virtual void OnUnpackSuccess(const FilePath& temp_dir,
                                const FilePath& extension_dir,
                                const base::DictionaryValue* original_manifest,
                                const Extension* extension) OVERRIDE;
 
   // Returns true if we can skip confirmation because the install was
   // whitelisted.
   bool CanSkipConfirmation();
 
+  void RunRequirementsChecker();

[Aaron Boodman, 2012/08/01 03:58:54]

Needs comments.

[Yoyo Zhou, 2012/08/02 22:23:30]

How about "Check Requirements"?

[eaugusti, 2012/08/03 01:06:26]

Done.

+
+  // Runs on the FILE thread. Callback from RequirementsChecker.
+  void RequirementsChecked(std::vector<std::string> errors);
+
   // Runs on the UI thread. Confirms with the user (via ExtensionInstallPrompt)
   // that it is OK to install this extension.
   void ConfirmInstall();
 
   // Runs on File thread. Install the unpacked extension into the profile and
   // notify the frontend.
   void CompleteInstall();
 
   // Result reporting.
   void ReportFailureFromFileThread(const CrxInstallerError& error);
@@ skipping 120 matching lines @@
   // Whether the installation was handled successfully. This is used to
   // indicate to the client whether the file should be removed and any UI
   // initiating the installation can be removed. This is different than whether
   // there was an error; if there was an error that rejects installation we
   // still consider the installation 'handled'.
   bool did_handle_successfully_;
 
   // Whether we should record an oauth2 grant upon successful install.
   bool record_oauth2_grant_;
 
+  // Whether we should produce an error if the manifest declares requirements
+  // that are not met. If false and there is an unmet requirement, the install
+  // will continue but the extension will be distabled.
+  bool error_on_unsported_requirements_;

[Yoyo Zhou, 2012/08/02 22:23:30]

Did you mean 'unsupported'?

[eaugusti, 2012/08/03 01:06:26]

Done.

+
+  scoped_ptr<RequirementsChecker> requirements_checker_;
+
+  std::vector<std::string> requirement_errors_;
+
   DISALLOW_COPY_AND_ASSIGN(CrxInstaller);
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_CRX_INSTALLER_H_