Make DownloadHistory observe manager, items

content/browser/download/download_item_factory.h

Index: content/browser/download/download_item_factory.h
diff --git a/content/browser/download/download_item_factory.h b/content/browser/download/download_item_factory.h
index db32503d1355da6c5deb87960823c56ff61f4ac0..55e8f9082e0da479c486dcc32cbc8853f66d7f9f 100644
--- a/content/browser/download/download_item_factory.h
+++ b/content/browser/download/download_item_factory.h
@@ -13,6 +13,7 @@
 
 #include "base/memory/scoped_ptr.h"
 #include "content/public/browser/download_id.h"
+#include "content/public/browser/download_item.h"
 
 struct DownloadCreateInfo;
 
@@ -24,7 +25,6 @@ class GURL;
 
 namespace content {
 class DownloadItem;
-struct DownloadPersistentStoreInfo;
 }
 
 namespace net {
@@ -40,7 +40,15 @@ public:
   virtual DownloadItemImpl* CreatePersistedItem(

[Randy Smith (Not in Mondays), 2012/08/28 13:11:49]

We need a better name for this.  Completed item?  "Finished" might be better,
since there can be cancelled/interrupted items in this list.

[benjhayden, 2012/09/10 19:02:56]

There can also be IN_PROGRESS entries in the history, which DII rewrites as
CANCELED.

[Randy Smith (Not in Mondays), 2012/09/11 16:30:34]

They still end up being finished when they're put into the core downloads system
through this interface.  And I think of the IN_PROGRESS vs. finished distinction
as the key one here--we're not hooking the download item up to a file &
URLRequest, we're just creating it to hang out by itself.  This name makes the
concept of persisting part of the interface.

But I don't care a whole lot; you can keep it like this if you want.

       DownloadItemImplDelegate* delegate,
       content::DownloadId download_id,
-      const content::DownloadPersistentStoreInfo& info,
+      const FilePath& path,
+      const GURL& url,
+      const GURL& referrer_url,
+      const base::Time& start_time,
+      const base::Time& end_time,
+      int64 received_bytes,
+      int64 total_bytes,
+      content::DownloadItem::DownloadState state,
+      bool opened,
       const net::BoundNetLog& bound_net_log) = 0;
 
   virtual DownloadItemImpl* CreateActiveItem(