Make DownloadHistory observe manager, items

content/browser/download/download_item_factory.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // The DownloadItemFactory is used to produce different DownloadItems.
 // It is separate from the DownloadManager to allow download manager
 // unit tests to control the items produced.
 
 #ifndef CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_ITEM_FACTORY_H_
 #define CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_ITEM_FACTORY_H_
 
 #include <string>
 
 #include "base/memory/scoped_ptr.h"
 #include "content/public/browser/download_id.h"
+#include "content/public/browser/download_item.h"
 
 struct DownloadCreateInfo;
 
 class DownloadItemImpl;
 class DownloadItemImplDelegate;
 class DownloadRequestHandleInterface;
 class FilePath;
 class GURL;
 
 namespace content {
 class DownloadItem;
-struct DownloadPersistentStoreInfo;
 }
 
 namespace net {
 class BoundNetLog;
 }
 
 namespace content {
 
 class DownloadItemFactory {
 public:
   virtual ~DownloadItemFactory() {}
 
   virtual DownloadItemImpl* CreatePersistedItem(

[Randy Smith (Not in Mondays), 2012/08/28 13:11:49]

We need a better name for this.  Completed item?  "Finished" might be better,
since there can be cancelled/interrupted items in this list.

[benjhayden, 2012/09/10 19:02:56]

There can also be IN_PROGRESS entries in the history, which DII rewrites as
CANCELED.

[Randy Smith (Not in Mondays), 2012/09/11 16:30:34]

They still end up being finished when they're put into the core downloads system
through this interface.  And I think of the IN_PROGRESS vs. finished distinction
as the key one here--we're not hooking the download item up to a file &
URLRequest, we're just creating it to hang out by itself.  This name makes the
concept of persisting part of the interface.

But I don't care a whole lot; you can keep it like this if you want.

       DownloadItemImplDelegate* delegate,
       content::DownloadId download_id,
-      const content::DownloadPersistentStoreInfo& info,
+      const FilePath& path,
+      const GURL& url,
+      const GURL& referrer_url,
+      const base::Time& start_time,
+      const base::Time& end_time,
+      int64 received_bytes,
+      int64 total_bytes,
+      content::DownloadItem::DownloadState state,
+      bool opened,
       const net::BoundNetLog& bound_net_log) = 0;
 
   virtual DownloadItemImpl* CreateActiveItem(
       DownloadItemImplDelegate* delegate,
       const DownloadCreateInfo& info,
       scoped_ptr<DownloadRequestHandleInterface> request_handle,
       const net::BoundNetLog& bound_net_log) = 0;
 
   virtual DownloadItemImpl* CreateSavePageItem(
       DownloadItemImplDelegate* delegate,
       const FilePath& path,
       const GURL& url,
       content::DownloadId download_id,
       const std::string& mime_type,
       const net::BoundNetLog& bound_net_log) = 0;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_ITEM_FACTORY_H_