Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issue 10661052: Remove the comment for CONFIGURATION_NAME (Closed)

Created:
8 years, 6 months ago by yongsheng
Modified:
8 years, 5 months ago
Reviewers:
John Grabowski, Nico
CC:
gyp-developer_googlegroups.com, John Grabowski, navabi1
Visibility:
Public.

Description

Remove the comment for CONFIGURATION_NAME It's used for chrome build on Android. Ant needs to know the build type from this variable. BUG= TEST=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M pylib/gyp/generator/make.py View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
yongsheng
See the patch for chrome for android: http://codereview.chromium.org/10669030/
8 years, 6 months ago (2012-06-26 09:06:46 UTC) #1
yongsheng
Nico, could you please help review it? If you're not the owner of this file, ...
8 years, 6 months ago (2012-06-26 09:09:40 UTC) #2
Nico
Hi, I searched the whole file for "CONFIGURATION_NAME" but didn't find it. Which line is ...
8 years, 6 months ago (2012-06-26 14:17:29 UTC) #3
John Grabowski
8 years, 6 months ago (2012-06-26 19:30:58 UTC) #4
yongsheng
On 2012/06/26 14:17:29, Nico wrote: > Hi, > > I searched the whole file for ...
8 years, 6 months ago (2012-06-27 08:07:35 UTC) #5
Nico
LGTM
8 years, 5 months ago (2012-06-27 14:33:40 UTC) #6
yongsheng
On 2012/06/27 14:33:40, Nico wrote: > LGTM thanks
8 years, 5 months ago (2012-06-29 02:16:06 UTC) #7
yongsheng
seems the 'commit' button doesn't work?
8 years, 5 months ago (2012-06-30 01:39:29 UTC) #8
Nico
Right, that doesn't work for gyp. I can land this for you.
8 years, 5 months ago (2012-06-30 01:40:37 UTC) #9
yongsheng
On 2012/06/30 01:40:37, Nico wrote: > Right, that doesn't work for gyp. I can land ...
8 years, 5 months ago (2012-06-30 06:51:21 UTC) #10
Nico
8 years, 5 months ago (2012-06-30 20:30:47 UTC) #11
r1424

Powered by Google App Engine
This is Rietveld 408576698