Issue 10660026: Don't allow statement-nodes in expression contexts.

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+81 lines, -15 lines)			Patch
M	lib/compiler/implementation/ssa/codegen_helpers.dart	View	1 2	7 chunks	+21 lines, -7 lines	2 comments	Download
M	lib/compiler/implementation/ssa/nodes.dart	View	1 2 3 4	3 chunks	+6 lines, -4 lines	0 comments	Download
M	lib/compiler/implementation/ssa/optimize.dart	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/compiler/implementation/ssa/tracer.dart	View	1 2 3	2 chunks	+5 lines, -3 lines	0 comments	Download
A	tests/language/issue3806_test.dart	View		1 chunk	+22 lines, -0 lines	0 comments	Download
A	tests/language/side_effect_throw_test.dart	View	1 2 3 4	1 chunk	+26 lines, -0 lines	2 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

http://codereview.chromium.org/10660026/diff/2001/lib/compiler/implementation/ssa/nodes.dart File lib/compiler/implementation/ssa/nodes.dart (right): http://codereview.chromium.org/10660026/diff/2001/lib/compiler/implementation/ssa/nodes.dart#newcode1005 lib/compiler/implementation/ssa/nodes.dart:1005: bool isOn = false; What does "isOn" mean? Could ...

8 years, 6 months ago (2012-06-27 10:08:37 UTC) #3

floitsch

8 years, 5 months ago (2012-06-27 12:23:02 UTC) #4

ngeoffray

LGTM https://chromiumcodereview.appspot.com/10660026/diff/12001/lib/compiler/implementation/ssa/codegen_helpers.dart File lib/compiler/implementation/ssa/codegen_helpers.dart (right): https://chromiumcodereview.appspot.com/10660026/diff/12001/lib/compiler/implementation/ssa/codegen_helpers.dart#newcode130 lib/compiler/implementation/ssa/codegen_helpers.dart:130: if (instruction.isStatement) { Please explain which inputs can ...

8 years, 4 months ago (2012-08-17 13:08:58 UTC) #5

floitsch

8 years, 3 months ago (2012-08-29 11:03:12 UTC) #6

Changes done in https://chromiumcodereview.appspot.com/10889022

https://chromiumcodereview.appspot.com/10660026/diff/12001/lib/compiler/imple...
File lib/compiler/implementation/ssa/codegen_helpers.dart (right):

https://chromiumcodereview.appspot.com/10660026/diff/12001/lib/compiler/imple...
lib/compiler/implementation/ssa/codegen_helpers.dart:130: if
(instruction.isStatement) {
On 2012/08/17 13:08:58, ngeoffray wrote:
> Please explain which inputs can be statements. Maybe we should change it to
> isJSStatement?
Changed to isJsStatement.

https://chromiumcodereview.appspot.com/10660026/diff/12001/tests/language/sid...
File tests/language/side_effect_throw_test.dart (right):

https://chromiumcodereview.appspot.com/10660026/diff/12001/tests/language/sid...
tests/language/side_effect_throw_test.dart:16: // 'n' must be a number, but we
are not allowed throw throw before we have
On 2012/08/17 13:08:58, ngeoffray wrote:
> throw throw -> to throw

Done.

Expand Messages | Collapse Messages

Issue 10660026: Don't allow statement-nodes in expression contexts. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Remove unnecessary code. #

Patch Set 3 : Address comments and rebase. #

Patch Set 4 : Renamed isOn to isEnabled. #

Patch Set 5 : Fix test for checked mode. #

Messages