Remove the HANDLED_EXTERNALLY status code.

chrome/browser/net/chrome_network_delegate.cc

Index: chrome/browser/net/chrome_network_delegate.cc
diff --git a/chrome/browser/net/chrome_network_delegate.cc b/chrome/browser/net/chrome_network_delegate.cc
index 5bd65b1d1790ce2e72eda8facafd2e1cfee73bac..4e09521bc4fc8f3988cba48c51d41f636c867f10 100644
--- a/chrome/browser/net/chrome_network_delegate.cc
+++ b/chrome/browser/net/chrome_network_delegate.cc
@@ -259,8 +259,9 @@ void ChromeNetworkDelegate::OnRawBytesRead(const net::URLRequest& request,
 
 void ChromeNetworkDelegate::OnCompleted(net::URLRequest* request,
                                         bool started) {
+  const ResourceRequestInfo* info = ResourceRequestInfo::ForRequest(request);
   if (request->status().status() == net::URLRequestStatus::SUCCESS ||
-      request->status().status() == net::URLRequestStatus::HANDLED_EXTERNALLY) {
+      (info && info->WasIgnoredByHandler())) {

[darin (slow to review), 2012/08/30 16:15:18]

Sorry, my suggestion was to write the code like this:

  if ((request->status().status() == net::URLRequestStatus::SUCCESS) ||
      (request->status().status() == net::URLRequestStatus::CANCELED &&
       info && info->WasIgnoredByHandler())) {
    ...

The check for CANCELED is obviously redundant here, but perhaps it makes the
code a bit clearer.  I am not strongly in favor of doing this, so if you
prefer leaving out the CANCELED check that is OK.

[mkosiba (inactive), 2012/08/31 14:45:10]

After a bit of browsing the code I think the line should be removed. I don't
think it's currently possible to hit this code path as
ExtensionWebRequestEventRouter::OnCompleted has a DCHECK(...status() ==
URLRequestStatus::SUCCESS) in it that none of the test code encounters.

The only place where we used the HANDLED_EXTERNALLY status code was in the
BufferedResourceHandle::UseAlternateNextHandler but the HANDLED_EXTERNALLY
status code from there ends up being sent to the renderer only (it's just used
as a parameter to a method, it's not actually set on the URLRequest's status
field).

     bool is_redirect = request->response_headers() &&
         net::HttpResponseHeaders::IsRedirectResponseCode(
             request->response_headers()->response_code());