Remove the HANDLED_EXTERNALLY status code.

chrome/browser/net/chrome_network_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/net/chrome_network_delegate.h"
 
 #include "base/logging.h"
 #include "chrome/browser/api/prefs/pref_member.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/content_settings/cookie_settings.h"
@@ skipping 241 matching lines @@
   performance_monitor::PerformanceMonitor::GetInstance()->BytesReadOnIOThread(
       request, bytes_read);
 
 #if defined(ENABLE_TASK_MANAGER)
   TaskManager::GetInstance()->model()->NotifyBytesRead(request, bytes_read);
 #endif  // defined(ENABLE_TASK_MANAGER)
 }
 
 void ChromeNetworkDelegate::OnCompleted(net::URLRequest* request,
                                         bool started) {
+  const ResourceRequestInfo* info = ResourceRequestInfo::ForRequest(request);
   if (request->status().status() == net::URLRequestStatus::SUCCESS ||
-      request->status().status() == net::URLRequestStatus::HANDLED_EXTERNALLY) {
+      (info && info->WasIgnoredByHandler())) {

[darin (slow to review), 2012/08/30 16:15:18]

Sorry, my suggestion was to write the code like this:

  if ((request->status().status() == net::URLRequestStatus::SUCCESS) ||
      (request->status().status() == net::URLRequestStatus::CANCELED &&
       info && info->WasIgnoredByHandler())) {
    ...

The check for CANCELED is obviously redundant here, but perhaps it makes the
code a bit clearer.  I am not strongly in favor of doing this, so if you
prefer leaving out the CANCELED check that is OK.

[mkosiba (inactive), 2012/08/31 14:45:10]

After a bit of browsing the code I think the line should be removed. I don't
think it's currently possible to hit this code path as
ExtensionWebRequestEventRouter::OnCompleted has a DCHECK(...status() ==
URLRequestStatus::SUCCESS) in it that none of the test code encounters.

The only place where we used the HANDLED_EXTERNALLY status code was in the
BufferedResourceHandle::UseAlternateNextHandler but the HANDLED_EXTERNALLY
status code from there ends up being sent to the renderer only (it's just used
as a parameter to a method, it's not actually set on the URLRequest's status
field).

     bool is_redirect = request->response_headers() &&
         net::HttpResponseHeaders::IsRedirectResponseCode(
             request->response_headers()->response_code());
     if (!is_redirect) {
       ExtensionWebRequestEventRouter::GetInstance()->OnCompleted(
           profile_, extension_info_map_.get(), request);
     }
   } else if (request->status().status() == net::URLRequestStatus::FAILED ||
              request->status().status() == net::URLRequestStatus::CANCELED) {
     ExtensionWebRequestEventRouter::GetInstance()->OnErrorOccurred(
@@ skipping 141 matching lines @@
 #endif
   return net::OK;
 }
 
 void ChromeNetworkDelegate::OnRequestWaitStateChange(
     const net::URLRequest& request,
     RequestWaitState state) {
   if (load_time_stats_)
     load_time_stats_->OnRequestWaitStateChange(request, state);
 }