Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: webkit/glue/resource_loader_bridge.h

Issue 10640019: Remove the HANDLED_EXTERNALLY status code. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: revert removing DCHECK from URLRequest::DoCancel Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/glue/resource_loader_bridge.h
diff --git a/webkit/glue/resource_loader_bridge.h b/webkit/glue/resource_loader_bridge.h
index 70db933767cda47e9f01be9c883245708b7aa6b3..f0db1eebd142643e2068bfaba57b99621a0b5248 100644
--- a/webkit/glue/resource_loader_bridge.h
+++ b/webkit/glue/resource_loader_bridge.h
@@ -274,8 +274,8 @@ class ResourceLoaderBridge {
SyncLoadResponse();
~SyncLoadResponse();
- // The response status.
- net::URLRequestStatus status;
+ // The response error code.
+ int error_code;
// The final URL of the response. This may differ from the request URL in
// the case of a server redirect.
@@ -334,9 +334,10 @@ class ResourceLoaderBridge {
virtual void OnReceivedCachedMetadata(const char* data, int len) { }
// Called when the response is complete. This method signals completion of
- // the resource load.ff
+ // the resource load.
virtual void OnCompletedRequest(
- const net::URLRequestStatus& status,
+ int error_code,
+ bool is_handled_externally,
darin (slow to review) 2012/08/10 18:03:02 nit: was_handled_externally
mkosiba (inactive) 2012/08/29 15:53:01 changed to 'ignored'.
const std::string& security_info,
const base::TimeTicks& completion_time) = 0;

Powered by Google App Engine
This is Rietveld 408576698