Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/url_request/url_request.cc

Issue 10640019: Remove the HANDLED_EXTERNALLY status code. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: revert removing DCHECK from URLRequest::DoCancel Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« net/base/net_errors.h ('K') | « net/url_request/url_fetcher_impl_unittest.cc ('k') | net/url_request/url_request_status.h » ('j') | webkit/glue/resource_loader_bridge.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request.cc
diff --git a/net/url_request/url_request.cc b/net/url_request/url_request.cc
index 8ea6325d819e072b5ad455b4c68867c90b7fa131..7528be33fab642a7bd8a5cac21aeef2487c85146 100644
--- a/net/url_request/url_request.cc
+++ b/net/url_request/url_request.cc
@@ -518,7 +518,6 @@ void URLRequest::CancelWithSSLError(int error, const SSLInfo& ssl_info) {
void URLRequest::DoCancel(int error, const SSLInfo& ssl_info) {
DCHECK(error < 0);
-
darin (slow to review) 2012/08/10 18:03:02 nit: gratuitous change
mkosiba (inactive) 2012/08/29 15:53:01 Done.
// If the URL request already has an error status, then canceling is a no-op.
// Plus, we don't want to change the error status once it has been set.
if (status_.is_success()) {
« net/base/net_errors.h ('K') | « net/url_request/url_fetcher_impl_unittest.cc ('k') | net/url_request/url_request_status.h » ('j') | webkit/glue/resource_loader_bridge.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698