webkit/appcache/appcache_request_handler.cc - Issue 10640019: Remove the HANDLED_EXTERNALLY status code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/appcache/appcache_request_handler.cc

Issue 10640019: Remove the HANDLED_EXTERNALLY status code. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: revert removing DCHECK from URLRequest::DoCancel Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webkit/appcache/appcache_request_handler.cc

diff --git a/webkit/appcache/appcache_request_handler.cc b/webkit/appcache/appcache_request_handler.cc

index 0f123a134bb52fe16ad9d8da5966f7b9e4a89d9d..d8da30f2f2888308d906dc23c6e491ebe93daf14 100644

--- a/webkit/appcache/appcache_request_handler.cc

+++ b/webkit/appcache/appcache_request_handler.cc

@@ -124,8 +124,7 @@ AppCacheURLRequestJob* AppCacheRequestHandler::MaybeLoadFallbackForResponse(

if (!found_fallback_entry_.has_response_id())

return NULL;

- if (request->status().status() == net::URLRequestStatus::CANCELED ||

- request->status().status() == net::URLRequestStatus::HANDLED_EXTERNALLY) {

+ if (request->status().status() == net::URLRequestStatus::CANCELED) {

// 6.9.6, step 4: But not if the user canceled the download.

return NULL;

}