Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(798)

Unified Diff: content/common/resource_dispatcher_unittest.cc

Issue 10640019: Remove the HANDLED_EXTERNALLY status code. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: revert removing DCHECK from URLRequest::DoCancel Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/resource_dispatcher_unittest.cc
diff --git a/content/common/resource_dispatcher_unittest.cc b/content/common/resource_dispatcher_unittest.cc
index e87463f40a425455750c74e1becc86fc58de9ac9..d9e6b2994db8f10bb484b531670df24248470bc6 100644
--- a/content/common/resource_dispatcher_unittest.cc
+++ b/content/common/resource_dispatcher_unittest.cc
@@ -13,6 +13,7 @@
#include "content/common/resource_dispatcher.h"
#include "content/common/resource_messages.h"
#include "content/public/common/resource_response.h"
+#include "net/base/net_errors.h"
#include "net/base/upload_data.h"
#include "net/http/http_response_headers.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -67,7 +68,8 @@ class TestRequestCallback : public ResourceLoaderBridge::Peer {
total_encoded_data_length_ += encoded_data_length;
}
- virtual void OnCompletedRequest(const net::URLRequestStatus& status,
+ virtual void OnCompletedRequest(int error_code,
+ bool handled_externally,
const std::string& security_info,
const base::TimeTicks& completion_time) {
EXPECT_FALSE(complete_);
@@ -245,7 +247,7 @@ class DeferredResourceLoadingTest : public ResourceDispatcherTest,
set_defer_loading(true);
ResourceResponseHead response_head;
- response_head.status.set_status(net::URLRequestStatus::SUCCESS);
+ response_head.error_code = net::OK;
IPC::Message* response_message =
new ResourceMsg_ReceivedResponse(0, 0, response_head);
@@ -298,7 +300,8 @@ class DeferredResourceLoadingTest : public ResourceDispatcherTest,
set_defer_loading(false);
}
- virtual void OnCompletedRequest(const net::URLRequestStatus& status,
+ virtual void OnCompletedRequest(int error_code,
+ bool handled_externally,
const std::string& security_info,
const base::TimeTicks& completion_time) {
}

Powered by Google App Engine
This is Rietveld 408576698