Remove the HANDLED_EXTERNALLY status code.

content/public/browser/resource_controller.h

Index: content/public/browser/resource_controller.h
diff --git a/content/public/browser/resource_controller.h b/content/public/browser/resource_controller.h
index 17c0eabafe7ef01aa03c3dad9b920d92acf04392..f5955dd1775efa066d3e22ed721074156921b957 100644
--- a/content/public/browser/resource_controller.h
+++ b/content/public/browser/resource_controller.h
@@ -12,6 +12,8 @@ namespace content {
 class ResourceController {
  public:
   virtual void Cancel() = 0;
+  virtual void CancelWithError(int error) = 0;

[darin (slow to review), 2012/08/10 18:03:02]

It looks like we don't need CancelWithError since nothing calls this function in
this CL.

[mkosiba (inactive), 2012/08/29 15:53:01]

Done.

+  virtual void HandledExternally() = 0;

[darin (slow to review), 2012/08/10 18:03:02]

This doesn't seem like the best name for this function.  We want to tell the
ResourceLoader to cancel the request _and_ to also forget that the request was
ever generated.  Maybe CancelAndIgnore or CancelAndSuppressErrorReporting? 
Neither of these suggestions strike me as all that great.

Another idea is to make this into a function that synthesizes a HTTP 204 "No
content" response.  CancelAndReturnNoContent or CancelAndSynthesizeNoContent or
CancelAndSimulateNoContent?

I'm having a hard time coming up with a good solution to this problem.

CancelAndIgnore is probably my preference at this point.  It at least conveys
the fact that the URLRequest will be canceled.  Using the term "ignore" is
consistent with the WebKit API where we have WebNavigationPolicyIgnore, which is
roughly equivalent.  Plus if you read all of ResourceController methods with a
suffix of "Request", this one would be CancelAndIgnore-Request, which is pretty
close to my description of "cancel the request and forget that the request was
ever generated."

I would then use terms like "was_ignored" instead of "was_handled_externally."

[mkosiba (inactive), 2012/08/29 15:53:01]

Ok, will go with CancelAndIgnore.

   virtual void Resume() = 0;
  protected:
   virtual ~ResourceController() {}