content/browser/renderer_host/redirect_to_file_resource_handler.cc - Issue 10640019: Remove the HANDLED_EXTERNALLY status code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/redirect_to_file_resource_handler.cc

Issue 10640019: Remove the HANDLED_EXTERNALLY status code. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: revert removing DCHECK from URLRequest::DoCancel Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/redirect_to_file_resource_handler.cc

diff --git a/content/browser/renderer_host/redirect_to_file_resource_handler.cc b/content/browser/renderer_host/redirect_to_file_resource_handler.cc

index d7f0ea3a7a383178e1bfc1d451f135a0a1a09f6c..72454337b0372a8ac81edda34b0c01f659eebcd8 100644

--- a/content/browser/renderer_host/redirect_to_file_resource_handler.cc

+++ b/content/browser/renderer_host/redirect_to_file_resource_handler.cc

@@ -61,7 +61,7 @@ bool RedirectToFileResourceHandler::OnResponseStarted(

int request_id,

ResourceResponse* response,

bool* defer) {

- if (response->head.status.is_success()) {

+ if (net::IsSuccessOrPending(response->head.error_code)) {

DCHECK(deletable_file_ && !deletable_file_->path().empty());

response->head.download_file_path = deletable_file_->path();

}