chrome/browser/renderer_host/intercept_navigation_resource_throttle_unittest.cc - Issue 10640019: Remove the HANDLED_EXTERNALLY status code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_host/intercept_navigation_resource_throttle_unittest.cc

Issue 10640019: Remove the HANDLED_EXTERNALLY status code. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: revert removing DCHECK from URLRequest::DoCancel Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/renderer_host/intercept_navigation_resource_throttle.cc ('k') | chrome/common/extensions/extension_localization_peer.h » ('j') | content/public/browser/resource_controller.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/renderer_host/intercept_navigation_resource_throttle_unittest.cc

diff --git a/chrome/browser/renderer_host/intercept_navigation_resource_throttle_unittest.cc b/chrome/browser/renderer_host/intercept_navigation_resource_throttle_unittest.cc

index d8de977f44ac73157962c3a0b7c09c08bffeda82..8a6fb53c6e5a3679c9f497a9e6891cf800207a49 100644

--- a/chrome/browser/renderer_host/intercept_navigation_resource_throttle_unittest.cc

+++ b/chrome/browser/renderer_host/intercept_navigation_resource_throttle_unittest.cc

@@ -68,7 +68,12 @@ class MockResourceController

// content::ResourceController

virtual void Cancel() {

- DCHECK(status_ == UNKNOWN);

+ NOTREACHED();

+ }

+ virtual void CancelWithError(int error) {

+ NOTREACHED();

+ }

+ virtual void HandledExternally() {

status_ = CANCELLED;

ContinueTestCase();

}