chrome/browser/net/chrome_network_delegate.cc - Issue 10640019: Remove the HANDLED_EXTERNALLY status code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/net/chrome_network_delegate.cc

Issue 10640019: Remove the HANDLED_EXTERNALLY status code. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: revert removing DCHECK from URLRequest::DoCancel Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/net/chrome_network_delegate.cc

diff --git a/chrome/browser/net/chrome_network_delegate.cc b/chrome/browser/net/chrome_network_delegate.cc

index 207bb089346dc800353c95a56abcc70a33788756..c1c48158af71b435ea0e4db9f9df2d0319c2e47e 100644

--- a/chrome/browser/net/chrome_network_delegate.cc

+++ b/chrome/browser/net/chrome_network_delegate.cc

@@ -233,8 +233,9 @@ void ChromeNetworkDelegate::OnRawBytesRead(const net::URLRequest& request,

void ChromeNetworkDelegate::OnCompleted(net::URLRequest* request,

bool started) {

+ const ResourceRequestInfo* info = ResourceRequestInfo::ForRequest(request);

if (request->status().status() == net::URLRequestStatus::SUCCESS ||

- request->status().status() == net::URLRequestStatus::HANDLED_EXTERNALLY) {

+ (info && info->HandledExternally())) {

bool is_redirect = request->response_headers() &&

net::HttpResponseHeaders::IsRedirectResponseCode(

request->response_headers()->response_code());