Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: runtime/bin/http.dart

Issue 10640017: Document the HttpClient uses KeepAlive, keeping sockets open for up to 60 seconds after a connectio… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/http.dart
diff --git a/runtime/bin/http.dart b/runtime/bin/http.dart
index d18ed339d2eb0ded2678f0d3d9e56cd026d5922a..2396a2a132e7ab6714d32cafc85ff991f4f5ec6d 100644
--- a/runtime/bin/http.dart
+++ b/runtime/bin/http.dart
@@ -623,7 +623,11 @@ interface HttpResponse default _HttpResponse {
/**
- * HTTP client factory.
+ * HTTP client factory. The [HttpClient] handles all the sockets associated
+ * with the [HttpClientConnection]s and when the endpoint supports it, it'll
Bill Hesse 2012/06/22 08:33:44 Isn't the real need for documentation on the HttpS
Søren Gjesse 2012/06/22 08:50:24 The HttpServer will keep running independently of
Anders Johnsen 2012/06/22 09:13:23 Done.
+ * use keep-alive. This means that sockets may be open up to 60 seconds after
Søren Gjesse 2012/06/22 08:12:02 "it'll use keep-alive" -> it will try to reuse ope
Søren Gjesse 2012/06/22 08:12:02 "may be open up to 60 seconds after a requests hav
Søren Gjesse 2012/06/22 08:16:01 Adding a bit more info. "it'll use keep-alive" ->
Anders Johnsen 2012/06/22 09:13:23 Done.
Anders Johnsen 2012/06/22 09:13:23 Done.
Anders Johnsen 2012/06/22 09:13:23 Done.
+ * a requests have completed. Use [:HttpClient.shutdown:] to force close the
+ * idle sockets.
*/
interface HttpClient default _HttpClient {
static final int DEFAULT_HTTP_PORT = 80;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698